Skip to content

Fix false positive in unused_parens caused by break #151811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 30, 2026
Merged

Fix false positive in unused_parens caused by break #151811

rust-bors merged 1 commit into from
Jan 30, 2026
+29 −1

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 29, 2026 •
edited by rustbot
Loading

Fixes #143256

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 29, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@mati865
Copy link
Member

mati865 commented Jan 29, 2026

@rustbot reroll

@rustbot rustbot assigned SparrowLii and unassigned mati865 Jan 29, 2026
@Kivooeo
Copy link
Member

Kivooeo commented Jan 29, 2026

r? me

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 29, 2026

📌 Commit 4803644 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 29, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 29, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151811 - chenyukang:yukang-fix-143256-unuse…
6d28f6c 
…d-parens-labeled-loops, r=Kivooeo

Fix false positive in unused_parens caused by break

Fixes rust-lang#143256
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 29, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 29, 2026
@bors
Auto merge of #151819 - JonathanBrouwer:rollup-hapcGKz, r=JonathanBro…
9e6db69 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`)
 - #151811 (Fix false positive in unused_parens caused by break)
 - #151817 (Fix missing syntax context in lifetime hygiene debug output)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 29, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151811 - chenyukang:yukang-fix-143256-unuse…
6c6eb6a 
…d-parens-labeled-loops, r=Kivooeo

Fix false positive in unused_parens caused by break

Fixes rust-lang#143256
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 29, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 29, 2026
@bors
Auto merge of #151837 - JonathanBrouwer:rollup-qIYP0mi, r=JonathanBro…
92324ee 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`)
 - #151811 (Fix false positive in unused_parens caused by break)
 - #151817 (Fix missing syntax context in lifetime hygiene debug output)
 - #151836 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test)
rust-bors bot pushed a commit that referenced this pull request Jan 30, 2026
@bors
Auto merge of #151837 - JonathanBrouwer:rollup-qIYP0mi, r=JonathanBro…
c996916 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`)
 - #151811 (Fix false positive in unused_parens caused by break)
 - #151817 (Fix missing syntax context in lifetime hygiene debug output)
 - #151836 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test)
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 30, 2026
@Zalathar
Rollup merge of rust-lang#151811 - chenyukang:yukang-fix-143256-unuse…
7308970 
…d-parens-labeled-loops, r=Kivooeo

Fix false positive in unused_parens caused by break

Fixes rust-lang#143256
@Zalathar Zalathar mentioned this pull request Jan 30, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 30, 2026
@bors
Auto merge of #151847 - Zalathar:rollup-sTU2VYU, r=Zalathar
10e08de 
Rollup of 6 pull requests

Successful merges:

 - #151777 (    Reduce generics use in the query system.)
 - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`)
 - #151811 (Fix false positive in unused_parens caused by break)
 - #151817 (Fix missing syntax context in lifetime hygiene debug output)
 - #151836 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test)
 - #151844 (rustc-dev-guide subtree update)
@Zalathar Zalathar mentioned this pull request Jan 30, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 30, 2026
@bors
Auto merge of #151852 - Zalathar:rollup-jdJCcDh, r=Zalathar
7d8ebe3 
Rollup of 5 pull requests

Successful merges:

 - #151777 (    Reduce generics use in the query system.)
 - #151808 (Document a safety condition for `TypedArena::alloc_raw_slice`)
 - #151811 (Fix false positive in unused_parens caused by break)
 - #151817 (Fix missing syntax context in lifetime hygiene debug output)
 - #151844 (rustc-dev-guide subtree update)
@rust-bors rust-bors bot merged commit 4500974 into rust-lang:main Jan 30, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 30, 2026
rust-timer added a commit that referenced this pull request Jan 30, 2026
@rust-timer
Unrolled build for #151811
68ac097 
Rollup merge of #151811 - chenyukang:yukang-fix-143256-unused-parens-labeled-loops, r=Kivooeo

Fix false positive in unused_parens caused by break

Fixes #143256
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 31, 2026
@bors
Auto merge of #151852 - Zalathar:rollup-jdJCcDh, r=Zalathar
7dae1ce 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#151777 (    Reduce generics use in the query system.)
 - rust-lang/rust#151808 (Document a safety condition for `TypedArena::alloc_raw_slice`)
 - rust-lang/rust#151811 (Fix false positive in unused_parens caused by break)
 - rust-lang/rust#151817 (Fix missing syntax context in lifetime hygiene debug output)
 - rust-lang/rust#151844 (rustc-dev-guide subtree update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

false positive unused_parens causes syntax error around labled loops with ifs

5 participants

@chenyukang @rustbot @mati865 @Kivooeo @SparrowLii