-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
add test for codegen of SIMD vector from array repeat #151869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
2423398 to
1369f03
Compare
This comment has been minimized.
This comment has been minimized.
|
Hmm, it is fixed on
Do we consider that fixed? |
|
I did file llvm/llvm-project#178940 for the wasm issue, cc @nikic |
|
For s390x without |
|
I'm a bit out of my depth here, but I would expect the transformation to a vector splat to happen much earlier than that. You're right that it does appear use information about what types are legal for the current target though. |
|
I think this is fine to merge if the test gets qualified with the appropriate architectures or whatever. |
|
@rustbot author Yeah, with appropriate ignore-X added seems OK to approve, though we should probably leave the issue open in that case? |
|
Reminder, once the PR becomes ready for a review, use |
1369f03 to
ac7219f
Compare
fixes #97804
It appears that this issue was fixed silently in LLVM 19. The original codegen was terrible, but starting at LLVM 19
optis able to generate good code.https://llvm.godbolt.org/z/5vq8scP6q
cc @programmerjake