Include assoc const projections in CFI trait object #151947
Merged
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
PG-exploit-mitigations
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use |
Contributor
|
@rustbot reroll |
Member
|
r? me |
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Feb 1, 2026
fmease
approved these changes
Feb 1, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 1, 2026
Include assoc const projections in CFI trait object Fixes rust-lang#151878 After rust-lang#150843, projections of trait objects should include assoc consts, but the cfi `trait_object_ty` still include only assoc types. So that we got the ICE `expected 1 projection but got 0`.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2026
…uwer Rollup of 10 pull requests Successful merges: - #150428 (UnixStream/UnixListener on Windows ) - #147400 (TryFrom<integer> for bool) - #150993 (std: sys: uefi: os: Implement join_paths) - #151483 (Add regression test for issue #138225) - #151568 (Update hexagon target linker configurations) - #151725 (Fix outdated Debian Ports ISO reference) - #151895 (Move UI tests batch) - #151923 (Fix ICE when projection error reporting sees opaque alias terms) - #151947 (Include assoc const projections in CFI trait object) - #151948 (Handle unbalanced delimiters gracefully in make_attr_token_stream)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
Rollup of 11 pull requests Successful merges: - #151756 (Avoid miri error in `slice::sort` under Stacked Borrows) - #147400 (TryFrom<integer> for bool) - #150993 (std: sys: uefi: os: Implement join_paths) - #151483 (Add regression test for issue #138225) - #151568 (Update hexagon target linker configurations) - #151725 (Fix outdated Debian Ports ISO reference) - #151895 (Move UI tests batch) - #151923 (Fix ICE when projection error reporting sees opaque alias terms) - #151947 (Include assoc const projections in CFI trait object) - #151948 (Handle unbalanced delimiters gracefully in make_attr_token_stream) - #151963 (Add regression test for negative literal in a range of unsigned type)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
Rollup of 11 pull requests Successful merges: - #151756 (Avoid miri error in `slice::sort` under Stacked Borrows) - #147400 (TryFrom<integer> for bool) - #150993 (std: sys: uefi: os: Implement join_paths) - #151483 (Add regression test for issue #138225) - #151568 (Update hexagon target linker configurations) - #151725 (Fix outdated Debian Ports ISO reference) - #151895 (Move UI tests batch) - #151923 (Fix ICE when projection error reporting sees opaque alias terms) - #151947 (Include assoc const projections in CFI trait object) - #151948 (Handle unbalanced delimiters gracefully in make_attr_token_stream) - #151963 (Add regression test for negative literal in a range of unsigned type)
rust-timer
added a commit
that referenced
this pull request
Feb 2, 2026
Rollup merge of #151947 - mu001999-contrib:fix/151878, r=fmease Include assoc const projections in CFI trait object Fixes #151878 After #150843, projections of trait objects should include assoc consts, but the cfi `trait_object_ty` still include only assoc types. So that we got the ICE `expected 1 projection but got 0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151878
After #150843, projections of trait objects should include assoc consts, but the cfi
trait_object_tystill include only assoc types. So that we got the ICEexpected 1 projection but got 0.