Skip to content

Comments

Fix next-solver ICE on PointeeSized goals#151962

Open
TaKO8Ki wants to merge 3 commits intorust-lang:mainfrom
TaKO8Ki:pointee-sized-next-solver-ice
Open

Fix next-solver ICE on PointeeSized goals#151962
TaKO8Ki wants to merge 3 commits intorust-lang:mainfrom
TaKO8Ki:pointee-sized-next-solver-ice

Conversation

@TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Feb 1, 2026

Fixes #151957

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@TaKO8Ki TaKO8Ki force-pushed the pointee-sized-next-solver-ice branch from 5342488 to 5bd2b85 Compare February 1, 2026 18:22
@mati865
Copy link
Member

mati865 commented Feb 3, 2026

@rustbot reroll

@rustbot rustbot assigned SparrowLii and unassigned mati865 Feb 3, 2026
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Feb 17, 2026

r? compiler

@rustbot rustbot assigned jieyouxu and unassigned SparrowLii Feb 17, 2026
@jieyouxu
Copy link
Member

r? types

@rustbot rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Feb 18, 2026
@rustbot rustbot assigned lcnr and unassigned jieyouxu Feb 18, 2026
@theemathas
Copy link
Contributor

theemathas commented Feb 18, 2026

I think this fixes the wrong problem, since the ICE can also occur outside the next-solver. See #151957 (comment)

@rperier
Copy link
Contributor

rperier commented Feb 18, 2026

We should not reach this point, self.predicate_must_hold_modulo_regions(...) should not being called. After investigation, there is a false positive match between PointeeSized from the current crate and core::marker::PointeeSized . The problem being, we could have exactly the same issue with some other traits in core::marker::* (like Unsize . I mean some false positives matches without ICE)

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 22, 2026

☔ The latest upstream changes (presumably #152965) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: entered unreachable code: PointeeSized is removed during lowering with -Z next-solver=globally and recursive associated type bound

9 participants