Skip to content

Ignore all debuginfo tests for LLDB that we do not run in CI#152010

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
workingjubilee:what-does-the-scouter-say-about-the-lldb-version-level
Feb 7, 2026
Merged

Ignore all debuginfo tests for LLDB that we do not run in CI#152010
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
workingjubilee:what-does-the-scouter-say-about-the-lldb-version-level

Conversation

@workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Feb 2, 2026

We only run LLDB 1500 in CI. Any test with a min-lldb-version above that is currently ignored. It's not clear any of these tests actually work with that LLDB version, and they definitely don't work on LLDB ~2100. So, ignore them until we fix debuginfo testing.

Fixes #151966

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member

Zalathar commented Feb 2, 2026

I haven’t checked that it actually works, but I think we already have an //@ ignore-lldb directive which is effectively this but more explicit.

@workingjubilee workingjubilee force-pushed the what-does-the-scouter-say-about-the-lldb-version-level branch from f479cb7 to b441a5d Compare February 2, 2026 22:12
@workingjubilee
Copy link
Member Author

Yep, that works!

@workingjubilee workingjubilee force-pushed the what-does-the-scouter-say-about-the-lldb-version-level branch from b441a5d to d978dd6 Compare February 2, 2026 22:15
@@ -1,4 +1,4 @@
//@ min-lldb-version: 1800
//@ ignore-lldb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using ignore-lldb for all cases, and found this case also.

@Mark-Simulacrum
Copy link
Member

Can we either put this in compiletest or leave an annotation for the ones that are lldb-version related? I expect we have some tests that are already ignored for other reasons on lldb and it would be nice to distinguish those cases, I think.

@workingjubilee
Copy link
Member Author

I mean, the min-lldb-version: 9000 variant was pretty distinctive!

I'll add a comment.

We only run LLDB 1500 in CI. Any test with a min-lldb-version above that
is currently ignored. It's not clear any of these tests actually work
with that LLDB version, and they definitely don't work on LLDB ~2100.
So, ignore them until we fix debuginfo testing.
@workingjubilee workingjubilee force-pushed the what-does-the-scouter-say-about-the-lldb-version-level branch from d978dd6 to 2b0cce0 Compare February 3, 2026 02:14
@Noratrieb
Copy link
Member

@bors r+ rollup
sounds good. alternatively we may want to just never use lldb on non-apple by default.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit 2b0cce0 has been approved by Noratrieb

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 7, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #148590 (Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0)
 - #150522 (Stabilize new inclusive range type and iterator type)
 - #152235 (Convert to inline diagnostics in `rustc_parse`)
 - #152267 (feat: Implement `int_from_ascii` for `NonZero<T>`)
 - #151576 (Stabilize `core::hint::cold_path`)
 - #151933 (Linker-plugin-based LTO: give an explanation how to use linker-plugin-lto with full LTO)
 - #152010 (Ignore all debuginfo tests for LLDB that we do not run in CI)
 - #152199 (Move `rustc_query_system::cache`.)
@rust-bors rust-bors bot merged commit 3391e4c into rust-lang:main Feb 7, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 7, 2026
rust-timer added a commit that referenced this pull request Feb 7, 2026
Rollup merge of #152010 - workingjubilee:what-does-the-scouter-say-about-the-lldb-version-level, r=Noratrieb

Ignore all debuginfo tests for LLDB that we do not run in CI

We only run LLDB 1500 in CI. Any test with a min-lldb-version above that is currently ignored. It's not clear any of these tests actually work with that LLDB version, and they definitely don't work on LLDB ~2100. So, ignore them until we fix debuginfo testing.

Fixes #151966
@workingjubilee workingjubilee deleted the what-does-the-scouter-say-about-the-lldb-version-level branch February 7, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLDB testing should be disabled

5 participants