Skip to content

Don't ICE on layout error in vtable computation#152120

Open
meithecatte wants to merge 1 commit intorust-lang:mainfrom
meithecatte:push-ltvwvkqrytno
Open

Don't ICE on layout error in vtable computation#152120
meithecatte wants to merge 1 commit intorust-lang:mainfrom
meithecatte:push-ltvwvkqrytno

Conversation

@meithecatte
Copy link
Contributor

@meithecatte meithecatte commented Feb 4, 2026 •
edited by rustbot
Loading

Fixes #152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

petrochenkov
petrochenkov reviewed Feb 9, 2026
View reviewed changes
@petrochenkov
Copy link
Contributor

petrochenkov commented Feb 9, 2026

Does it make sense to also include the original testcase?

Yes, let's add that test case as well.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@meithecatte
Copy link
Contributor Author

meithecatte commented Feb 10, 2026

Now with more tests. Still using match instead of let else because I don't see how to make a let else work in that context.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026
@petrochenkov
Copy link
Contributor

petrochenkov commented Feb 10, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

📌 Commit 58335d6 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152120 - meithecatte:push-ltvwvkqrytno, r=p…
4169874 
…etrochenkov

Don't ICE on layout error in vtable computation

Fixes rust-lang#152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152120 - meithecatte:push-ltvwvkqrytno, r=p…
a89edff 
…etrochenkov

Don't ICE on layout error in vtable computation

Fixes rust-lang#152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152451 - JonathanBrouwer:rollup-1mjEpG1, r=JonathanBro…
e1f5019 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #149937 (try enabling `linker-messages` by default again)
 - #151733 (Use function shims to make sure EII works on apple targets)
 - #152120 (Don't ICE on layout error in vtable computation)
 - #152419 (Move more query system code)
 - #152431 (Restrict the set of things that const stability can be applied to)
 - #152436 (Reenable a GCI+mGCA+GCPT test case)
 - #151142 (Support ADT types in type info reflection)
 - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2)
 - #152146 (mGCA: Add associated const type check)
 - #152372 (style: remove unneeded trailing commas)
 - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable)
 - #152397 (Update books)
 - #152441 (Fix typos and grammar in top-level and src/doc documentation)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2026
@matthiaskrgr
Rollup merge of rust-lang#152120 - meithecatte:push-ltvwvkqrytno, r=p…
43dc57e 
…etrochenkov

Don't ICE on layout error in vtable computation

Fixes rust-lang#152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 10, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 11, 2026
@matthiaskrgr
Rollup merge of rust-lang#152120 - meithecatte:push-ltvwvkqrytno, r=p…
4a32e96 
…etrochenkov

Don't ICE on layout error in vtable computation

Fixes rust-lang#152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 11, 2026
@matthiaskrgr
Rollup merge of rust-lang#152120 - meithecatte:push-ltvwvkqrytno, r=p…
c22620f 
…etrochenkov

Don't ICE on layout error in vtable computation

Fixes rust-lang#152030.

Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 11, 2026
@bors
Auto merge of #152475 - matthiaskrgr:rollup-jGnoUNQ, r=matthiaskrgr
01370f7 
Rollup of 10 pull requests

Successful merges:

 - #152120 (Don't ICE on layout error in vtable computation)
 - #152419 (Move more query system code)
 - #152431 (Restrict the set of things that const stability can be applied to)
 - #152436 (Reenable a GCI+mGCA+GCPT test case)
 - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2)
 - #152146 (mGCA: Add associated const type check)
 - #152372 (style: remove unneeded trailing commas)
 - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable)
 - #152397 (Update books)
 - #152441 (Fix typos and grammar in top-level and src/doc documentation)
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Feb 11, 2026

@bors r-
#152475 (comment)

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 11, 2026

Commit 58335d6 has been unapproved.

This PR was contained in a rollup (#152475), which was also unapproved.

@tmiasko tmiasko mentioned this pull request Feb 11, 2026
Open
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@meithecatte
Copy link
Contributor Author

meithecatte commented Feb 12, 2026

Sorry for the broken rollup, I had mistakenly assumed that debuginfo=0 is the default for the test suite. Should be fixed now.

Should we do a try build of x86_64-gnu-debug just in case?

@meithecatte
Copy link
Contributor Author

meithecatte commented Feb 14, 2026

ah, @rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE when coercing a too large array to a trait object

4 participants

@meithecatte @rustbot @petrochenkov @matthiaskrgr