Add note for ?Sized params in int-ptr casts diag#152159
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 12, 2026
Merged
Add note for ?Sized params in int-ptr casts diag#152159rust-bors[bot] merged 1 commit intorust-lang:mainfrom
?Sized params in int-ptr casts diag#152159rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnTitor
force-pushed
the
issue-74756
branch
from
3264991 to
aa7c785
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
mati865
reviewed
Feb 10, 2026
| | | | ||
| | consider casting this expression to `*const ()`, then using `core::ptr::from_raw_parts` | ||
| | | ||
| = note: the type parameter `T` is not known to be `Sized`, so this pointer may be wide |
Member
There was a problem hiding this comment.
Sorry for the long time until the review.
I'm not sure if this message is helpful, but I don't have a better idea.
r? @estebank who had commented on that issue
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 11, 2026
Add note for `?Sized` params in int-ptr casts diag Close rust-lang#74756
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 11, 2026
Add note for `?Sized` params in int-ptr casts diag Close rust-lang#74756
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 12, 2026
Add note for `?Sized` params in int-ptr casts diag Close rust-lang#74756
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
Rollup of 17 pull requests Successful merges: - #142415 (Add note when inherent impl for a alias type defined outside of the crate) - #142680 (Fix passing/returning structs with the 64-bit SPARC ABI) - #150768 (Don't compute FnAbi for LLVM intrinsics in backends) - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151814 (layout: handle rigid aliases without params) - #151863 (Borrowck: simplify diagnostics for placeholders) - #152159 (Add note for `?Sized` params in int-ptr casts diag) - #152434 (Clarify names of `QueryVTable` functions for "executing" a query) - #152478 (Remove tm_factory field from CodegenContext) - #152498 (Partially revert "resolve: Update `NameBindingData::vis` in place") - #152316 (fix: add continue) - #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter) - #152425 (Port #![test_runner] to the attribute parser) - #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif) - #152485 (fix issue#152482) - #152495 (Clean up some subdiagnostics) - #152502 (Implement `BinaryHeap::from_raw_vec`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #74756