Skip to content

fix: rhs_span to rhs_span_new#152315

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cuiweixie:bugfix-span
Feb 9, 2026
Merged

fix: rhs_span to rhs_span_new#152315
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
cuiweixie:bugfix-span

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Feb 8, 2026

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: borrowck, compiler
  • borrowck, compiler expanded to 22 candidates
  • Random selection from 13 candidates

jieyouxu
jieyouxu requested changes Feb 8, 2026
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a regression test.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jieyouxu jieyouxu assigned jieyouxu and unassigned mati865 Feb 8, 2026
@cuiweixie
Copy link
Contributor Author

cuiweixie commented Feb 8, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@cuiweixie cuiweixie requested a review from jieyouxu February 8, 2026 08:53
@jieyouxu
Copy link
Member

jieyouxu commented Feb 9, 2026

I will also be blunt and ask: did you use an LLM to generate the response to my question?

  • If not, I apologize.
  • If so, I implore that you don't pipe my question to LLMs then feed the output back to me. I don't care about grammar or whatever, it doesn't even have to be English.

For the change itself, I'm okay with merging as long as the overly-verbose comments and ineffective test is dropped.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026
@cuiweixie
Copy link
Contributor Author

cuiweixie commented Feb 9, 2026

I will also be blunt and ask: did you use an LLM to generate the response to my question?

  • If not, I apologize.
  • If so, I implore that you don't pipe my question to LLMs then feed the output back to me. I don't care about grammar or whatever, it doesn't even have to be English.

For the change itself, I'm okay with merging as long as the overly-verbose comments and ineffective test is dropped.

@rustbot author

sorry, I use chinese write reply and use llm to beatify the reply. maybe i can reply in english directly next time even it's not that english.

@jieyouxu
Copy link
Member

jieyouxu commented Feb 9, 2026 •
edited
Loading

sorry, I use chinese write reply and use llm to beatify the reply.

I don't need beautiful replies, I'd like to hear what you think. I don't care about grammar/spelling etc.

maybe i can reply in english directly next time even it's not that english.

Yes, this is perfectly fine! I can read Chinese too, but I can't read what you want to say behind the fluff that the LLM is outputting.

I think generally other reviewers will want to read what you say too, including in PR descriptions, discussions and code comments, instead of fluff from LLM. Please keep in mind rust-lang/compiler-team#893.

jieyouxu
jieyouxu approved these changes Feb 9, 2026
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 9, 2026

📌 Commit 40a264c has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152315 - cuiweixie:bugfix-span, r=jieyouxu
52bef9a 
fix: rhs_span to rhs_span_new
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 9, 2026
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 9, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152315 - cuiweixie:bugfix-span, r=jieyouxu
ace0387 
fix: rhs_span to rhs_span_new
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 9, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 9, 2026
@bors
Auto merge of #152399 - matthiaskrgr:rollup-uDIDnAN, r=matthiaskrgr
72f50fc 
Rollup of 12 pull requests

Successful merges:

 - #152388 (`rust-analyzer` subtree update)
 - #151613 (Align `ArrayWindows` trait impls with `Windows`)
 - #152134 (Set crt_static_allow_dylibs to true for Emscripten target)
 - #152166 (cleanup some more things in `proc_macro::bridge`)
 - #152236 (compiletest: `-Zunstable-options` for json targets)
 - #152287 (Fix an ICE in the vtable iteration for a trait reference in const eval when a supertrait not implemented)
 - #142957 (std: introduce path normalize methods at top of `std::path`)
 - #145504 (Add some conversion trait impls)
 - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
 - #152315 (fix: rhs_span to rhs_span_new)
 - #152327 (Check stalled coroutine obligations eagerly)
 - #152377 (Rename the query system's `JobOwner` to `ActiveJobGuard`, and include `key_hash`)
rust-bors bot pushed a commit that referenced this pull request Feb 9, 2026
@bors
Auto merge of #152399 - matthiaskrgr:rollup-uDIDnAN, r=matthiaskrgr
1fc607b 
Rollup of 12 pull requests

Successful merges:

 - #152388 (`rust-analyzer` subtree update)
 - #151613 (Align `ArrayWindows` trait impls with `Windows`)
 - #152134 (Set crt_static_allow_dylibs to true for Emscripten target)
 - #152166 (cleanup some more things in `proc_macro::bridge`)
 - #152236 (compiletest: `-Zunstable-options` for json targets)
 - #152287 (Fix an ICE in the vtable iteration for a trait reference in const eval when a supertrait not implemented)
 - #142957 (std: introduce path normalize methods at top of `std::path`)
 - #145504 (Add some conversion trait impls)
 - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
 - #152315 (fix: rhs_span to rhs_span_new)
 - #152327 (Check stalled coroutine obligations eagerly)
 - #152377 (Rename the query system's `JobOwner` to `ActiveJobGuard`, and include `key_hash`)
rust-bors bot pushed a commit that referenced this pull request Feb 9, 2026
@bors
Auto merge of #152399 - matthiaskrgr:rollup-uDIDnAN, r=matthiaskrgr
18d13b5 
Rollup of 12 pull requests

Successful merges:

 - #152388 (`rust-analyzer` subtree update)
 - #151613 (Align `ArrayWindows` trait impls with `Windows`)
 - #152134 (Set crt_static_allow_dylibs to true for Emscripten target)
 - #152166 (cleanup some more things in `proc_macro::bridge`)
 - #152236 (compiletest: `-Zunstable-options` for json targets)
 - #152287 (Fix an ICE in the vtable iteration for a trait reference in const eval when a supertrait not implemented)
 - #142957 (std: introduce path normalize methods at top of `std::path`)
 - #145504 (Add some conversion trait impls)
 - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
 - #152315 (fix: rhs_span to rhs_span_new)
 - #152327 (Check stalled coroutine obligations eagerly)
 - #152377 (Rename the query system's `JobOwner` to `ActiveJobGuard`, and include `key_hash`)
@rust-bors rust-bors bot merged commit 7ecefd0 into rust-lang:main Feb 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 9, 2026
rust-timer added a commit that referenced this pull request Feb 9, 2026
@rust-timer
Unrolled build for #152315
d63dfce 
Rollup merge of #152315 - cuiweixie:bugfix-span, r=jieyouxu

fix: rhs_span to rhs_span_new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cuiweixie @rustbot @jieyouxu @mati865