Skip to content

mgca: Type-check field of array expr const args#152458

Closed
alv-around wants to merge 1 commit intorust-lang:mainfrom
alv-around:issue-152125-fix
Closed

mgca: Type-check field of array expr const args#152458
alv-around wants to merge 1 commit intorust-lang:mainfrom
alv-around:issue-152125-fix

Conversation

@alv-around
Copy link

@alv-around alv-around commented Feb 10, 2026

fixes #152125

r? @BoxyUwU

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2026

changes to the core type system

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 10, 2026
Copy link
Member

@BoxyUwU BoxyUwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this, your changes looks correct to me. I intend to merge #152492 instead however as the author was originally assigned to the linked issue.

If you're interested in working on other issues too that would be very welcome :)

View changes since this review

@BoxyUwU BoxyUwU removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2026
@alv-around
Copy link
Author

Thanks for the update. I understand wanting to stick with the original assignee for the final merge.

However, I noticed that the first commit in the PR in question is nearly identical to the solution I submitted a day earlier. While the fix is straightforward, it’s a bit disappointing to see my work replicated rather than collaborated on or cherry-picked, especially after I reached out to coordinate.

I’m still happy to contribute to the project, but I’d hope for a bit more transparency regarding attribution in the future. On to the next one :)

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 24, 2026

Yeah it is quite unfortunate how it worked out :( Sorry for your first experience here being quite meh

@BoxyUwU BoxyUwU closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mGCA: type check arguments to array expressions

3 participants