Skip to content

fix issue#152482 #152485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Feb 12, 2026
+1 −1
Merged

fix issue#152482 #152485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bootstrap/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,7 +1316,7 @@ def bootstrap(args):
# Give a hard error if `--config` or `RUST_BOOTSTRAP_CONFIG` are set to a missing path,
# but not if `bootstrap.toml` hasn't been created.
if not using_default_path or os.path.exists(toml_path):
with open(toml_path) as config:
Copy link
Member

@jieyouxu jieyouxu Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: we should go through bootstrap.py and make sure we specific explicit open() encodings, as far as I am aware there is a reasonable desire to want to make a future change in Python 3.* where open() defaults to UTF-8 encoding, which could break open() on binary files called elsewhere in this script.

with open(toml_path, encoding="utf-8") as config:
config_toml = config.read()
else:
config_toml = ""
Expand Down
Loading