Fix feature gating for new try bikeshed expressions#152519
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 13, 2026
Merged
Fix feature gating for new try bikeshed expressions#152519rust-bors[bot] merged 1 commit intorust-lang:mainfrom
try bikeshed expressions#152519rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
lqd
reviewed
Feb 12, 2026
| @@ -0,0 +1,12 @@ | |||
| //@ run-pass | |||
Member
Author
There was a problem hiding this comment.
No, probably not. You're thinking check-pass instead?
Member
There was a problem hiding this comment.
Yeah. It should be enough, right? Since this is in the frontend, it shouldn't need codegen (which is the build-pass variety), and check should work.
Member
There was a problem hiding this comment.
Indeed, check-pass more than suffices.
fmease
approved these changes
Feb 12, 2026
Member
There was a problem hiding this comment.
Thanks! r=me with build-pass → check-pass @bors rollup
| @@ -0,0 +1,12 @@ | |||
| //@ run-pass | |||
Member
There was a problem hiding this comment.
Indeed, check-pass more than suffices.
Member
There was a problem hiding this comment.
Usually I put test cases that ensure the feature gate happens before expansion in the dedicated tests/ui/feature-gates/feature-gate-$FEATURE.rs right next to the other test cases. I guess a separate test file is also fine.
Member
Author
There was a problem hiding this comment.
Ah, I wasn't sure that both in the same file worked. If that's normal, then great, I'd rather not have another file.
I kept the homogeneous one in the separate file because the warning seems to only be there when the error didn't happen earlier (which is good).
fmease
added
S-waiting-on-author
fmease
approved these changes
Feb 12, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 13, 2026
Fix feature gating for new `try bikeshed` expressions r? fmease Fixes rust-lang#152501
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Rollup of 18 pull requests Successful merges: - #150551 (Compute localized outlives constraints lazily) - #150752 (Update libc to v0.2.181) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152514 (Collect active query jobs into struct `QueryJobMap`) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152232 (Add must_use for FileTimes) - #152329 (Simplify parallel! macro) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152519 (Fix feature gating for new `try bikeshed` expressions) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion) - #152550 (Port #[prelude_import] to the attribute parser) - #152552 (Add 2048-bit HvxVectorPair support to Hexagon SIMD ABI checks)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Rollup of 17 pull requests Successful merges: - #150551 (Compute localized outlives constraints lazily) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152514 (Collect active query jobs into struct `QueryJobMap`) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152232 (Add must_use for FileTimes) - #152329 (Simplify parallel! macro) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152519 (Fix feature gating for new `try bikeshed` expressions) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion) - #152550 (Port #[prelude_import] to the attribute parser) - #152552 (Add 2048-bit HvxVectorPair support to Hexagon SIMD ABI checks) Failed merges: - #152515 (Extract `DepKindVTable` constructors to their own module)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? fmease
Fixes #152501