Remove deprecated_safe and its corresponding feature gate#152554
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 14, 2026
Merged
Remove deprecated_safe and its corresponding feature gate#152554rust-bors[bot] merged 1 commit intorust-lang:mainfrom
deprecated_safe and its corresponding feature gate#152554rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
JonathanBrouwer
force-pushed
the
remove_deprecated_safe
branch
from
02a3071 to
b463c4b
Compare
9 tasks
Bryntet
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
do we have to keep this test?
Contributor
Author
There was a problem hiding this comment.
Fair point, I think we can indeed just remove it, it's not really testing anything anymore
JonathanBrouwer
force-pushed
the
remove_deprecated_safe
branch
from
b463c4b to
42a3c86
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 13, 2026
…safe, r=jdonszelmann Remove `deprecated_safe` and its corresponding feature gate This unimplements the feature gate for tracking issue rust-lang#94978 The author of that tracking issue and the MCP seem to no longer exist Afaik we can just do this, but let me know if I'm wrong Because this feature has been idle for 3+ years, and it is in the way to finish the attribute refactoring (rust-lang#131229 (comment)) When someone wants to do work on it the feature gate can be re-added r? @jdonszelmann
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 13, 2026
…safe, r=jdonszelmann Remove `deprecated_safe` and its corresponding feature gate This unimplements the feature gate for tracking issue rust-lang#94978 The author of that tracking issue and the MCP seem to no longer exist Afaik we can just do this, but let me know if I'm wrong Because this feature has been idle for 3+ years, and it is in the way to finish the attribute refactoring (rust-lang#131229 (comment)) When someone wants to do work on it the feature gate can be re-added r? @jdonszelmann
This was referenced Feb 13, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
…uwer Rollup of 14 pull requests Successful merges: - #152323 (Fix ICE in borrowck when recovering `fn_sig` for `-> _`) - #152469 (Remove unused features) - #152515 (Extract `DepKindVTable` constructors to their own module) - #152555 (Port `#[rustc_diagnostic_item]` to the new attribute parsers) - #152218 (Report unconstrained region in hidden types lazily) - #152356 (Improve the `inline_fluent!` macro) - #152392 (Fix ICE in supertrait_vtable_slot when supertrait has missing generics) - #152407 (Add regression test for type_const with unit struct ctor under mGCA) - #152440 (Fix typos and grammar in compiler and build documentation) - #152536 (bootstrap: add explicit UTF-8 encoding to text-mode open() calls) - #152554 (Remove `deprecated_safe` and its corresponding feature gate) - #152556 (doc: move riscv64a23-unknown-linux-gnu to tier 2) - #152563 (Replace "bug" with "issue" in triagebot ping messages) - #152565 (fix missleading error for tuple ctor) Failed merges: - #152512 (core: Implement feature `float_exact_integer_constants`) - #152296 (Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
…uwer Rollup of 14 pull requests Successful merges: - #152323 (Fix ICE in borrowck when recovering `fn_sig` for `-> _`) - #152469 (Remove unused features) - #152515 (Extract `DepKindVTable` constructors to their own module) - #152555 (Port `#[rustc_diagnostic_item]` to the new attribute parsers) - #152218 (Report unconstrained region in hidden types lazily) - #152356 (Improve the `inline_fluent!` macro) - #152392 (Fix ICE in supertrait_vtable_slot when supertrait has missing generics) - #152407 (Add regression test for type_const with unit struct ctor under mGCA) - #152440 (Fix typos and grammar in compiler and build documentation) - #152536 (bootstrap: add explicit UTF-8 encoding to text-mode open() calls) - #152554 (Remove `deprecated_safe` and its corresponding feature gate) - #152556 (doc: move riscv64a23-unknown-linux-gnu to tier 2) - #152563 (Replace "bug" with "issue" in triagebot ping messages) - #152565 (fix missleading error for tuple ctor) Failed merges: - #152512 (core: Implement feature `float_exact_integer_constants`) - #152296 (Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser)
rust-timer
added a commit
that referenced
this pull request
Feb 14, 2026
Rollup merge of #152554 - JonathanBrouwer:remove_deprecated_safe, r=jdonszelmann Remove `deprecated_safe` and its corresponding feature gate This unimplements the feature gate for tracking issue #94978 The author of that tracking issue and the MCP seem to no longer exist Afaik we can just do this, but let me know if I'm wrong Because this feature has been idle for 3+ years, and it is in the way to finish the attribute refactoring (#131229 (comment)) When someone wants to do work on it the feature gate can be re-added r? @jdonszelmann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unimplements the feature gate for tracking issue #94978
The author of that tracking issue and the MCP seem to no longer exist
Afaik we can just do this, but let me know if I'm wrong
Because this feature has been idle for 3+ years, and it is in the way to finish the attribute refactoring (#131229 (comment))
When someone wants to do work on it the feature gate can be re-added
r? @jdonszelmann