Merged
Conversation
Collaborator
|
r? @dianqk rustbot has assigned @dianqk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-tidy
Member
|
|
rust-cloud-vms
bot
force-pushed
the
refactor
branch
from
ab0451f to
5fe5510
Compare
Member
|
@rustbot reroll |
Member
|
I can't commit to a full review at the moment, but I will say that this looks good from what I've seen. |
Member
Author
|
To elaborate on the changes, I made a few directory adjustments, following the FIXME in |
Member
|
I think it's better to not squash, because the individual commits are good logical boundaries. And in that case, please fix the typo in the first commit message ( After that, I'll r+. |
Member
|
r? me |
rust-cloud-vms
bot
force-pushed
the
refactor
branch
from
5fe5510 to
c92f384
Compare
Member
Author
|
Oh, there was a typo.😅 I corrected it. |
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 15, 2026
Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 15, 2026
Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 15, 2026
Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 15, 2026
Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 15, 2026
Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 15, 2026
Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
This was referenced Feb 15, 2026
rust-timer
added a commit
that referenced
this pull request
Feb 15, 2026
Rollup merge of #152604 - reddevilmidzy:refactor, r=Zalathar Relocate some tests `dynamically-sized-types` -> `dst` `underscore-imports` -> `imports/underscore-imports` `btreemap`, `hashmap` -> `collections/btreemap`, `collections/hashmap` `higher-ranked-trait-bounds` -> `higher-ranked/trait-bounds` `meta` -> `compiletest-self-test`, `bootstrap` After the review, I'll squash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dynamically-sized-types->dstunderscore-imports->imports/underscore-importsbtreemap,hashmap->collections/btreemap,collections/hashmaphigher-ranked-trait-bounds->higher-ranked/trait-boundsmeta->compiletest-self-test,bootstrapAfter the review, I'll squash.