Build: Add stdenv.cc.cc.lib to Nix dependencies#152708
Build: Add stdenv.cc.cc.lib to Nix dependencies#152708rust-bors[bot] merged 1 commit intorust-lang:mainfrom
stdenv.cc.cc.lib to Nix dependencies#152708Conversation
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
I'm not familiar with Nix, but #127620 seems relevant. In that issue, it seems like further steps were required to get it working (cc @lolbinarycat) |
Indeed it is. @lolbinarycat should we close the issue with this PR?
In our case, only the first line is required, removing it definitely breaks the build as indicated in the original description. The second line does not seem necessary for us at least. |
|
There's a list of explanations for each dep just above your change, can you add an explanation for stdenv.cc.cc.lib too? This basically LGTM, but I'd like to wait for someone who knows more about Nix/the usage here to comment. |
Otherwise, it systematically fails on: ``` error: process didn't exit successfully: `[...]/rust/build/bootstrap/debug/rustc [...]/rust/build/bootstrap/debug/rustc -vV` (exit status: 127) --- stderr [...]/rust/build/x86_64-unknown-linux-gnu/stage1/bin/rustc: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory ``` for us at least. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
5352c81 to
751b7d5
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Yup, done.
@roblabla might be of help here. |
|
Going through the U.R.L.O. thread, the problem is that only stage0 compiler is patched. |
|
What do you mean exactly? I don't quite understand. |
|
I was asking whether this change fixes stage1 rustc. If so, the "rust-stage0-dependencies" name is confusing. At least it got me for a while. |
|
Yes, it seems to be for stage1 indeed: the message preceding the error was For stage0, I guess the same change could also be applied to |
|
Sorry for repeatedly pushing the same concern. You're right that stage0 rustc doesn't need dynamic Checking all usages of |
|
We currently only build the |
|
Given that this does seem to be a strict improvement for now, I'm happy to merge this unless there's any immediate ideas to make this a more complete fix? |
|
Strange that nix has anything do with windows target. |
|
@bors r+ rollup |
….lib, r=clubby789 Build: Add `stdenv.cc.cc.lib` to Nix dependencies Otherwise, it systematically fails on: ``` error: process didn't exit successfully: `[...]/rust/build/bootstrap/debug/rustc [...]/rust/build/bootstrap/debug/rustc -vV` (exit status: 127) --- stderr [...]/rust/build/x86_64-unknown-linux-gnu/stage1/bin/rustc: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory ``` for us at least. Closes rust-lang#127620. @rustbot label T-bootstrap A-reproducibility
…uwer Rollup of 5 pull requests Successful merges: - #149366 (GVN: consider constants of primitive types as deterministic) - #152779 (Clarify aspects of query macros) - #152958 (`rustc_queries` simplifications) - #149783 (stabilize `cfg_select!`) - #152708 (Build: Add `stdenv.cc.cc.lib` to Nix dependencies)
…uwer Rollup of 5 pull requests Successful merges: - #149366 (GVN: consider constants of primitive types as deterministic) - #152779 (Clarify aspects of query macros) - #152958 (`rustc_queries` simplifications) - #149783 (stabilize `cfg_select!`) - #152708 (Build: Add `stdenv.cc.cc.lib` to Nix dependencies)
….lib, r=clubby789 Build: Add `stdenv.cc.cc.lib` to Nix dependencies Otherwise, it systematically fails on: ``` error: process didn't exit successfully: `[...]/rust/build/bootstrap/debug/rustc [...]/rust/build/bootstrap/debug/rustc -vV` (exit status: 127) --- stderr [...]/rust/build/x86_64-unknown-linux-gnu/stage1/bin/rustc: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory ``` for us at least. Closes rust-lang#127620. @rustbot label T-bootstrap A-reproducibility
…uwer Rollup of 8 pull requests Successful merges: - #149366 (GVN: consider constants of primitive types as deterministic) - #152779 (Clarify aspects of query macros) - #152958 (`rustc_queries` simplifications) - #152385 (Feature gate for defaulted associated type_consts with associated_type_defaults ) - #152708 (Build: Add `stdenv.cc.cc.lib` to Nix dependencies) - #152921 (Add build.rustdoc option to bootstrap config) - #152926 (Fix ICE when an associated type is wrongly marked as `final`) - #152927 (Index expressions rendered the index: subexpression as the id, instea…)
…uwer Rollup of 7 pull requests Successful merges: - #152779 (Clarify aspects of query macros) - #152958 (`rustc_queries` simplifications) - #152385 (Feature gate for defaulted associated type_consts with associated_type_defaults ) - #152708 (Build: Add `stdenv.cc.cc.lib` to Nix dependencies) - #152921 (Add build.rustdoc option to bootstrap config) - #152926 (Fix ICE when an associated type is wrongly marked as `final`) - #152927 (Index expressions rendered the index: subexpression as the id, instea…)
Rollup merge of #152708 - PaulDance:patches/nix-stdenv.cc.cc.lib, r=clubby789 Build: Add `stdenv.cc.cc.lib` to Nix dependencies Otherwise, it systematically fails on: ``` error: process didn't exit successfully: `[...]/rust/build/bootstrap/debug/rustc [...]/rust/build/bootstrap/debug/rustc -vV` (exit status: 127) --- stderr [...]/rust/build/x86_64-unknown-linux-gnu/stage1/bin/rustc: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory ``` for us at least. Closes #127620. @rustbot label T-bootstrap A-reproducibility
|
Thanks! |
Otherwise, it systematically fails on:
for us at least. Closes #127620.
@rustbot label T-bootstrap A-reproducibility