Remove QuerySystemFns#153078
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Feb 26, 2026
Merged
Conversation
It has a single use and doesn't provide any real value. Removing it allows the removal of two `for<'tcx>` qualifiers.
`QuerySystem` has two function pointers: `encode_query_results` and `try_mark_green`. These exist so that `rustc_middle` can call functions from upstream crates. But we have a more general mechanism for that: hooks. So this commit converts these two cases into hooks.
rustbot
added
A-query-system
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…etrochenkov Remove `QuerySystemFns` Two small query-related cleanups. r? petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…etrochenkov Remove `QuerySystemFns` Two small query-related cleanups. r? petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…etrochenkov Remove `QuerySystemFns` Two small query-related cleanups. r? petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…etrochenkov Remove `QuerySystemFns` Two small query-related cleanups. r? petrochenkov
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
…uwer Rollup of 13 pull requests Successful merges: - #153079 (Revert "Move aarch64-apple dist builder to dynamic llvm linking") - #148146 (CI: use alternative disks if available) - #149937 (spliit out `linker-info` from `linker-messages`) - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - #153075 (mGCA: Lower negated literals directly and reject non-integer negations) - #153078 (Remove `QuerySystemFns`) - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153063 (`is_ty_must_use`: do not require a `span` argument) - #153071 (Update books) - #153092 (Remove redundant self usages) - #153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - #153091 (Migration of `LintDiagnostic` - part 4)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
Rollup of 13 pull requests Successful merges: - #148146 (CI: use alternative disks if available) - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - #153075 (mGCA: Lower negated literals directly and reject non-integer negations) - #153078 (Remove `QuerySystemFns`) - #153089 (interpret: avoid dummy spans in the stacktrace) - #153111 (Refactor url_parts to return is_absolute instead of out param) - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153063 (`is_ty_must_use`: do not require a `span` argument) - #153071 (Update books) - #153092 (Remove redundant self usages) - #153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - #153091 (Migration of `LintDiagnostic` - part 4)
rust-timer
added a commit
that referenced
this pull request
Feb 26, 2026
Rollup merge of #153078 - nnethercote:rm-QuerySystemFns, r=petrochenkov Remove `QuerySystemFns` Two small query-related cleanups. r? petrochenkov
Contributor
|
@rust-timer build 761cc7e |
This comment has been minimized.
This comment has been minimized.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 26, 2026
Rollup of 13 pull requests Successful merges: - rust-lang/rust#148146 (CI: use alternative disks if available) - rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations) - rust-lang/rust#153078 (Remove `QuerySystemFns`) - rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace) - rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param) - rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument) - rust-lang/rust#153071 (Update books) - rust-lang/rust#153092 (Remove redundant self usages) - rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
Collaborator
|
Finished benchmarking commit (761cc7e): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -5.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 492.161s -> 479.39s (-2.59%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small query-related cleanups.
r? petrochenkov