Extract LLVM, rustc::back, misc from rustc #15511
Conversation
|
I didn't measure the peak resident memory building rustc, but here are the before and after bin sizes: You can see the majority of |
|
cc #560 |
| llvm::llvm::LLVMInitializeMipsTarget(); | ||
| llvm::llvm::LLVMInitializeMipsTargetMC(); | ||
| llvm::llvm::LLVMInitializeMipsAsmPrinter(); | ||
| llvm::llvm::LLVMInitializeMipsAsmParser(); |
There was a problem hiding this comment.
Perhaps there is an organization where you write "llvm" at most twice?
|
I'd like @alexcrichton to look this over as well, but it looks good to me. |
|
@alexcrichton I fixed the |
| pub dst: Path, | ||
| pub lib_search_paths: Vec<Path>, | ||
| pub os: abi::Os, | ||
| pub maybe_ar_prog: Option<String> | ||
| } |
There was a problem hiding this comment.
This is an interesting pattern, not sure I'm a huge fan but it certainly helps breaking deps!
|
@alexcrichton Do you want to not do this? |
|
I very much like the idea of splitting up rustc both in terms of build times and lines between dependencies. I don't want to go too far down the road of As in, I'm not sure that this is the best organization, but there is a clear path forward that I'm happy with, so I'm fine merging this with future improvements on the way. |
It is a wrapper around LLVM.
Indicate that anything that can be extracted here should and that things with syntax deps should be split out someday.
Just some leftover junk from extracting llvm.
This makes it much saner for clients to use the library since they don't have to worry about shadowing one llvm with another.
This was my weekend project, to start breaking up rustc. It first pulls out LLVM into `rustc_llvm`, then parts of `rustc::back` and `rustc::util` to `rustc_back`. The immediate intent is just to reduce the size of rustc, to reduce memory pressure when building rustc, but this is also a good starting point for further refactoring. The `rustc_back` crate is definitely misnamed (`rustc::back` was never a very cohesive module anyway) - it's mostly just somewhere to stuff parts of rustc that don't have many deps. Right now it's main dep is `syntax`; it has no dep on `rustc_llvm`. Some next steps might be to split `rustc_back` into `rustc_util` (with no `syntax` dep), and `rustc_syntax_util` (with a syntax dep); move the rest of `rustc::util` into `rustc_syntax_util`; move all of `rustc::front` to a new crate, `rustc_front`. At that point the refactoring necessary to keep extracting crates will get harder.
This was my weekend project, to start breaking up rustc. It first pulls out LLVM into
rustc_llvm, then parts ofrustc::backandrustc::utiltorustc_back. The immediate intent is just to reduce the size of rustc, to reduce memory pressure when building rustc, but this is also a good starting point for further refactoring.The
rustc_backcrate is definitely misnamed (rustc::backwas never a very cohesive module anyway) - it's mostly just somewhere to stuff parts of rustc that don't have many deps. Right now it's main dep issyntax; it has no dep onrustc_llvm.Some next steps might be to split
rustc_backintorustc_util(with nosyntaxdep), andrustc_syntax_util(with a syntax dep); move the rest ofrustc::utilintorustc_syntax_util; move all ofrustc::frontto a new crate,rustc_front. At that point the refactoring necessary to keep extracting crates will get harder.