Removing recursion from find_mut in treemap #15540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| find_mut(&mut self.root, key) | ||
| let mut current: &'a mut Option<Box<TreeNode<K, V>>> = &mut self.root; | ||
| loop { | ||
| let temp = current; //hack to appease borrowck |
There was a problem hiding this comment.
The style is to have a space after the //.
|
@huonw I believe I've addressed all of your issues |
|
Cool, looks good. r=me if you squash the commits into one. |
|
@huonw done |
|
Thanks @gankro! |
|
Do we have benchmarks on this? |
|
@pcwalton not for the mutable variant. I could write some if you want, but I think this change is desirable if only to have uniform code duplication. |
bors
added a commit
that referenced
this pull request
Jul 9, 2014
Removing recursion from TreeMap implementation, because we don't have TCO. No need to add ```O(logn)``` extra stack frames to search in a tree. I find it curious that ```find_mut``` and ```find``` basically duplicated the same logic, but in different ways (iterative vs recursive), possibly to maneuvre around mutability rules, but that's a more fundamental issue to deal with elsewhere. Thanks to acrichto for the magic trick to appease borrowck (another issue to deal with elsewhere).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing recursion from TreeMap implementation, because we don't have TCO. No need to add
O(logn)extra stack frames to search in a tree.I find it curious that
find_mutandfindbasically duplicated the same logic, but in different ways (iterative vs recursive), possibly to maneuvre around mutability rules, but that's a more fundamental issue to deal with elsewhere.Thanks to acrichto for the magic trick to appease borrowck (another issue to deal with elsewhere).