Run ldconfig on install #15597
Merged
Run ldconfig on install #15597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ldconfig fails it emits a warning. This is very possible when installing to a non-system directory, so the warning tries to indicate that it may not be a problem.
| @@ -293,9 +293,11 @@ elif [ "$CFG_OSTYPE" = "Darwin" ] | |||
| then | |||
| CFG_LD_PATH_VAR=DYLD_LIBRARY_PATH | |||
| CFG_OLD_LD_PATH_VAR=$DYLD_LIBRARY_PATH | |||
| UNIX=1 | |||
There was a problem hiding this comment.
On OSX I don't seem to have ldconfig installed, perhaps it's only installed by default on linux?
There was a problem hiding this comment.
OS X might not have a cache for this stuff.
|
Updated to only run ldconfig on linux. |
bors
added a commit
that referenced
this pull request
Jul 12, 2014
If ldconfig fails it emits a warning. This is very possible when installing to a non-system directory, so the warning tries to indicate that it may not be a problem.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…thand, r=HKalbasi
Field shorthand overwritten in promote local to const assist
Currently, running `promote_local_to_const` on the following:
```rust
struct Foo {
bar: usize,
}
fn main() {
let $0bar = 0;
let foo = Foo { bar };
}
```
Results in:
```rust
struct Foo {
bar: usize,
}
fn main() {
const BAR: usize = 0;
let foo = Foo { BAR };
}
```
But instead should be something like:
```rust
struct Foo {
bar: usize,
}
fn main() {
const BAR: usize = 0;
let foo = Foo { bar: BAR };
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ldconfig fails it emits a warning. This is very possible when installing
to a non-system directory, so the warning tries to indicate that it may
not be a problem.