Use a nicer Show impl for Name #15598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +62,12 @@ impl Show for Ident { | |||
| } | |||
| } | |||
|
|
|||
| impl Show for Name { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| write!(f, "\"{}\"", token::get_name(*self).get()) | |||
There was a problem hiding this comment.
Maybe this could include the number too? (e.g. to help with debugging gensym'd symbols?)
There was a problem hiding this comment.
That was my comment, too...
|
Will add. |
fix for rust-bindgen
|
Can you add a test for the |
|
I'm not sure I can... the pretty tests already test unit structs. I think bindgen is constructing the ast in a peculiar way (it only happens for C structs which contain only unions!). |
|
There seems to be explicit handling of unit-like structs above where you added the extra clause, and if we don't know why that's not getting triggered, perhaps we could leave it to another PR? |
|
I'll spend a few more minutes debugging rust-bindgen before splitting out that commit |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
…eykril fix: preceding QualifiedPathType for into_to_from assist fixes rust-lang#15598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.