Skip to content

Conversation

lucidd
Copy link
Contributor

@lucidd lucidd commented Jul 11, 2014

This fixes #15474

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this use {:#}? The documentation claims that the # flag only applies to integral formatting.

Also, [..many] is unnecessary, you can just say many.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah hah, the documentation is wrong. # on slices omits the brackets. That really should be documented.

@lilyball
Copy link
Contributor

r=me if you tweak the [..many] pattern as suggested. Well, r=me even if you don't, but I'd prefer it if you made that change first.

@lucidd
Copy link
Contributor Author

lucidd commented Jul 11, 2014

@kballard thanks for the feedback. You are right the [..many] is unnecessary i will change that first.

@lilyball
Copy link
Contributor

It occurs to me that I have no idea if rustdoc has an infrastructure for testing this sort of thing. If it does, it would be a good idea to add a test.

@lucidd
Copy link
Contributor Author

lucidd commented Jul 11, 2014

@kballard i couldn't find any tests related to that. Do you think this kind of test should be added?

@alexcrichton
Copy link
Member

Sadly we don't have a whole lot of tests for rustdoc right now, it's ok to add this without a test.

bors added a commit that referenced this pull request Jul 13, 2014
@bors bors closed this Jul 13, 2014
@bors bors merged commit 3d2fd5e into rust-lang:master Jul 13, 2014
flip1995 added a commit to flip1995/rust that referenced this pull request Sep 4, 2025
Forgot to do this at the start of the week. Will be back on the 15th.
(That's also the reason why I forgot about the meeting. Sorry for that!)

r? @ghost

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc should render 1-tuples as (T,)
4 participants