Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a first batch of diagnostics to have error codes #15615

Merged
merged 1 commit into from Jul 15, 2014
Merged

Convert a first batch of diagnostics to have error codes #15615

merged 1 commit into from Jul 15, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2014

No description provided.

@ghost
Copy link
Author

ghost commented Jul 11, 2014

I'm not sure this is the right way to go about this. Converting all the diagnostics to have codes is tempting but maybe we should instead do it on an individual basis when we're confident a diagnostic is going to stay. I reckon all the language changes before 1.0 will have significant impact on the stability of these.

@alexcrichton
Copy link
Member

cc @brson

I think that having error codes before we have explanations is useful because if someone runs into error EXXXX without an explanation it's a great way to get started contributing to rust (if you're up to the task!). I personally see the error codes as frozen for life once emitted, but I have a feeling we can continue to add digits in the future if necessary, or even change letters, so I don't think we have to worry too much about wasting some codes here and there.

@ghost
Copy link
Author

ghost commented Jul 12, 2014

@alexcrichton Good point! Which reminds me I should add a note to the compiler's output on how to help contribute descriptions for the undocumented diagnostics.

bors added a commit that referenced this pull request Jul 15, 2014
@bors bors closed this Jul 15, 2014
@bors bors merged commit a5fe176 into rust-lang:master Jul 15, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2023
…-lints, r=Veykril

Refactor/fix clippy lints

As title says.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants