Rename Option in tutorial to workaround iteration bug. #15707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not a fan of prefixing enum Maybe<T> {
Just(T),
Nothing
} |
|
Point taken. In hindsight, it does look better. |
| `Stack<int>`, and `Maybe<int>`. | ||
|
|
||
| The last type in that example, `Maybe`, is already defined in Rust as | ||
| the type `Option` with the constants `Some(T)` and `None`. |
There was a problem hiding this comment.
Also, maybe it should not be 'constants', but 'variants'
treeman
changed the title
|
Closing, this was fixed by #15809 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
…nfig, r=lnicola Add configuration for the default action of the status bar click action in VSCode Fixes rust-lang#15441 Please suggest any changes if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #15409.
I opted to rename
OptiontoMyOptionso we won't get an error if we simply type in all code.Explicitly mention that rust has an
Optiontype and in the following code snippets we use rust's built in type. It should be clear what's going on I hope.