dataflow: removed the CFGIndex to bitset mapping. #15742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? anyone |
Part of addressing 15019.
Calls to methods like `each_bit_on_entry_frozen` and `each_gen_bit_frozen` now go to the `each_bit_on_entry` and `each_gen_bit` methods.
bors
added a commit
that referenced
this pull request
Jul 18, 2014
Removed `index_to_bitset` field and `_frozen` methods. Drive-by: Added some missing docs on the `each_bit` method. Drive-by: Put in a regular pattern: when calling `compute_id_range`, ensure `words_per_id > 0` by either asserting it or checking and returning early. (The prior code did the latter in a few cases where necessary, but debugging is much aided by the asserts.) Fix #15019.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
index_to_bitsetfield and_frozenmethods.Drive-by: Added some missing docs on the
each_bitmethod.Drive-by: Put in a regular pattern: when calling
compute_id_range, ensurewords_per_id > 0by either asserting it or checking and returning early. (The prior code did the latter in a few cases where necessary, but debugging is much aided by the asserts.)Fix #15019.