Implement ASCII case-related method on Vec<u8> and &[u8] #15777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that this doesn't need an RFC, it's ok to do outside of that process. Could you leave the old names in places like so? #[deprecated = "this trait has been renamed to `AsciiExt`"]
pub use StrAsciiExt = AsciiExt;I would prefer to keep the |
|
Oh, I tried |
|
ping? Sorry this fell under the radar, this is probably good to go with a rebase. |
… and implement them on Vec<u8> / &[u8]. [breaking-change]
The deprecation warning does not seem to be emitted right now, but hopefully that’ll be fixed.
|
I’d forgotten about this myself. Rebased. |
bors
added a commit
that referenced
this pull request
Jul 30, 2014
When dealing with HTTP request or responses, many tokens are case-insensitive in the ASCII range but the bytes from the network are not necessarily valid UTF-8. **[breaking-change]** Rather than adding new very similar traits, this re-uses the `std::ascii::OwnedStrAsciiExt` and `std::ascii::StrAsciiExt` traits, but rename to remove `Str` since that does not apply for bytes. This PR also makes `std::ascii::ASCII_UPPER_MAP` and `std::ascii::ASCII_LOWER_MAP`, the lookup table all these methods are based on, public. In case there is something else related to ASCII case we haven’t thought of yet, that can be implemented outside of libstd without duplicating the tables. Although this is a breaking change, I thought this could do without an RFC since the relevant traits are not in the prelude. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with HTTP request or responses, many tokens are case-insensitive in the ASCII range but the bytes from the network are not necessarily valid UTF-8.
[breaking-change] Rather than adding new very similar traits, this re-uses the
std::ascii::OwnedStrAsciiExtandstd::ascii::StrAsciiExttraits, but rename to removeStrsince that does not apply for bytes.This PR also makes
std::ascii::ASCII_UPPER_MAPandstd::ascii::ASCII_LOWER_MAP, the lookup table all these methods are based on, public. In case there is something else related to ASCII case we haven’t thought of yet, that can be implemented outside of libstd without duplicating the tables.Although this is a breaking change, I thought this could do without an RFC since the relevant traits are not in the prelude.
r? @alexcrichton