librustc: Check structure constructors against their types. #15938
Conversation
| /// parameters. | ||
| /// | ||
| /// If the path has no type parameters and the corresponding type has no | ||
| /// type parameters, `None` is returned. If the path has type parameters and |
There was a problem hiding this comment.
First sentence here, I assume you mean "and the corresponding type has no type parameters".
|
@kballard Fixed. |
| path.span, | ||
| format!("structure constructor specifies a \ | ||
| structure of type `{}`, but this \ | ||
| structure has type `{}`: {}", |
There was a problem hiding this comment.
Do we use the full word "structure" in other errors, instead of "struct"? Similarly, do we have precedent for the phrase "structure constructor"? My inclination is to call it a "struct literal".
There was a problem hiding this comment.
Yes, we use "structure" in other errors.
|
I realized this doesn't handle some edge cases. Going to rework a bit. |
|
Just yesterday I was wondering if |
|
I assume this closes #9620 too. |
|
re-r? @huonw |
| x: 3i, | ||
| y: 4i, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Travis says this line has trailing whitespace.
This breaks code like:
struct Point<T> {
x: T,
y: T,
}
let pt = Point::<bool> {
x: 1,
y: 2,
};
Change this code to not contain a type error. For example:
let pt = Point::<int> {
x: 1,
y: 2,
};
Closes rust-lang#9620.
Closes rust-lang#15875.
[breaking-change]
|
@huonw Fixed. |
…over, r=Veykril feat: add hover display for trait assoc items This PR enable preview assoc items when hover on `trait`  inspired by rust-lang/rust-analyzer#15847
This breaks code like:
Change this code to not contain a type error. For example:
Closes #15875.
[breaking-change]
r? @huonw