Add no_default_methods attribute and the associated lint #16051
Conversation
| impl_methods.iter().map(|m| { m.pe_ident().name }).collect(); | ||
| if !trait_set.is_subset(&impl_set) { | ||
| cx.span_lint(MISSING_OVERRIDE, attr.span, | ||
| "some default methods are not overridden"); |
There was a problem hiding this comment.
This should mention the names of the missing methods somewhere.
There was a problem hiding this comment.
Agreed. Either in this message, or in an associated note.
|
Updated. |
|
As the compiler starts to grow more and more lints, this may be a lint which is niche enough to live outside the compiler now. Any thoughts on this @pnkfelix? |
|
@alexcrichton does the fact that it needs an associated attribute a motivation for still coupling it to |
|
The lint + attribute should work fine as a plugin. |
|
I would be fine with this living in the rustc code base itself (i.e. it seems like a relatively simple lint to support). But I also am sympathetic to wanting it to live outside the code base. @alexcrichton do we have a standard recipe for serving up plugins that live outside the compiler and making them discoverable? Or is that gated on some larger piece of infrastructure that still remains to be written? If we can host it elsewhere today, then that's fine; but I wouldn't want to gate this feature today on that infrastructure, especially since we can factor it out and move it elsewhere later if need be. |
It seems like something useful for the compiler itself too? E.g. enforcing that certain |
We do indeed! Cargo has first-class support for plugins, and discoverability will happen when we create a registry. While useful for the compiler, this is something that we'll have to maintain until the end of time if it's added to the standard distribution and it's unclear how useful this will be on a general basis. |
|
@alexcrichton Since we do not yet have discoverability, Is there already an example |
|
@pnkfelix here's an example that I think is up to date: https://github.com/huonw/spellck#spellck |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
…ks, r=Veykril fix: support auto-closing for triple backticks It might fix rust-lang#16051, see rust-lang/rust-analyzer#16051 (comment)
…ks, r=Veykril fix: support auto-closing for triple backticks It might fix rust-lang#16051, see rust-lang/rust-analyzer#16051 (comment)
Fix #14220.