Byte literals! #16115
Closed
Byte literals! #16115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 0x73, //'s' as u8, | ||
| 0x74, //'t' as u8, | ||
| 0, 0, 0, 1 ]; | ||
| pub static metadata_encoding_version : &'static [u8] = &[b'r', b'u', b's', b't', 0, 0, 0, 1 ]; |
There was a problem hiding this comment.
Is this better than
pub static metadata_encoding_version : &'static [u8] = b"rust\0\0\0\x01";
There was a problem hiding this comment.
It's a little clearer that the [0, 0, 0, 1] is meant to be incremented separately if they're distinct, but it doesn't matter too much as we don't really change this ever.
There was a problem hiding this comment.
Yeah, I tried that too, but it seemed like the zeros and ones should be numbers.
There was a problem hiding this comment.
This PR started as a joke :) @alexcrichton said on IRC that this had never changed, so let’s change it… but not actually changing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.