Update guide.md #16222
Closed
Update guide.md #16222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encourage users to access rustup.sh over HTTPS from github.com not HTTP from www.rust-lang.org
|
This is not the proper fix for this. The proper fix is #16123 |
|
Agreed -- this is definitely a workaround. However, shouldn't we encourage users to only access rustup.sh over HTTPS? It's very scary to give root to untrusted content provided over HTTP. |
|
I don't see how this would solve the problem. You'll still be pulling the nightly binaries down over HTTP and running the a script in that tarball. |
|
That is also true. |
|
Right! I didn't think about the underlying binaries... Closing PR. |
9 tasks
This was referenced Oct 22, 2022
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 3, 2024
…, r=Veykril add unresolved-assoc-item assist I tried to copy from private-assoc-item for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encourage users to access rustup.sh over HTTPS from github.com not HTTP from www.rust-lang.org. See #16123 for details