Rolling up PRs in the queue #16308
Closed
Rolling up PRs in the queue #16308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_WIN32 is defined for 64-bit builds as well, so test for _WIN64 first.
This is important when building with --disable-jemalloc: unlike jemalloc, msvcrt does not align on 16 bytes unless asked to.
… has a legitimate need to set them.
The original trick used to trigger unwinds would not work with GCC's implementation of SEH, so I had to invent a new one: rust_try now consists of two routines: the outer one, whose handler triggers unwinds, and the inner one, that stops unwinds by having a landing pad that swallows exceptions and passes them on to the outer routine via a normal return.
This ended up passing through the lexer but dying later on in parsing when it wasn't handled. The strategy taken was to copy the `str_lit` funciton, but adapt it for bytes. Closes rust-lang#16278
There's a good long comment explaining why. The tl;dr; is that I have no idea why this is necessary, but it gets --test to work on windows which is something, right? cc rust-lang#13259 cc rust-lang#16275 cc rust-lang/cargo#302
For a good measure, implemented target_record_stack_bounds for 32-bit Windows as well.
… to separate text from the edge of the newly added background.
bors
added a commit
that referenced
this pull request
Aug 6, 2014
That's really kind of ugly. Can you not provide a better merge message? At least do something like
|
|
Ideally you'd construct something equivalent to the merge messages bors constructs. I don't know how feasible that is; are you doing this by hand, doing this with a script that operates on GitHub, or doing this with a script that operates on a list of remotes you've given it? |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2024
Builtin derives are hygienic Closes rust-lang/rust-analyzer#16295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.