librustc: Allow trait bounds on structures and enumerations, and check #16432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Could you also add tests for these cases? (I think they're mentioned in the RFC as well)
struct Foo2<T> {
x: Foo<T>, // error
}
impl<T> Foo<T> { } // error
fn foo<T>(f: Foo<T>) {} // error (with a generic T)There was a problem hiding this comment.
Could you also add some run-pass tests like the small ones mentioned in the RFC?
|
Looks basically good modulo but that we need to check in type definitions (as I now see that @alexcrichton also pointed out). That should be a minor diff I believe. Let me know when it's ready and I'll review again quickly. |
|
@nikomatsakis re-r? |
|
@bors: retry |
them during kind checking. This implements RFC rust-lang#11. Closes rust-lang#15759.
bors
added a commit
that referenced
this pull request
Aug 17, 2014
them during kind checking. This implements RFC #11. Closes #15759. r? @nikomatsakis
17 tasks
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2024
fix: preserve where clause when builtin derive Closes rust-lang#16432.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
them during kind checking.
This implements RFC #11.
Closes #15759.
r? @nikomatsakis