Skip to content

libsyntax: Don't strip types and lifetimes from single-segment paths in #16454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

libsyntax: Don't strip types and lifetimes from single-segment paths in #16454

wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

patterns.

This breaks code like:

fn main() {
    match Some("foo") {
        None::<int> => {}
        Some(_) => {}
    }
}

Change this code to not contain a type error. For example:

fn main() {
    match Some("foo") {
        None::<&str> => {}
        Some(_) => {}
    }
}

Closes #16353.

[breaking-change]

r? @huonw

@pcwalton
libsyntax: Don't strip types and lifetimes from single-segment paths in
857ba98 
patterns.

This breaks code like:

    fn main() {
        match Some("foo") {
            None::<int> => {}
            Some(_) => {}
        }
    }

Change this code to not contain a type error. For example:

    fn main() {
        match Some("foo") {
            None::<&str> => {}
            Some(_) => {}
        }
    }

Closes rust-lang#16353.

[breaking-change]
bors added a commit that referenced this pull request Aug 12, 2014
@bors
auto merge of #16454 : pcwalton/rust/types-in-path-patterns, r=brson
4bb4a43 
patterns.

This breaks code like:

    fn main() {
        match Some("foo") {
            None::<int> => {}
            Some(_) => {}
        }
    }

Change this code to not contain a type error. For example:

    fn main() {
        match Some("foo") {
            None::<&str> => {}
            Some(_) => {}
        }
    }

Closes #16353.

[breaking-change]

r? @huonw
@bors bors closed this Aug 12, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 11, 2024
@bors
Auto merge of rust-lang#16454 - Veykril:break-return-postfix, r=Veykril
82674e2 
feat: Add break and return postfix keyword completions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic parameters in some paths in patterns are ignored
3 participants
@pcwalton @brson @bors