Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 14 fixes #16471

Merged
merged 6 commits into from
Aug 21, 2014
Merged

Chapter 14 fixes #16471

merged 6 commits into from
Aug 21, 2014

Conversation

EduardoBautista
Copy link
Contributor

Just some small fixes for the guide. The cargo stuff is probably because of an update.

@brson
Copy link
Contributor

brson commented Aug 13, 2014

r? @steveklabnik

@steveklabnik
Copy link
Member

Yes, r=me

@steveklabnik
Copy link
Member

And thanks @EduardoBautista , you're right, this is probably cargo upgrades.

@EduardoBautista
Copy link
Contributor Author

No problem @steveklabnik. Also, I just noticed that cargo is now outputting file names like this:

file:///Users/eduardobautista/Projects/guessing_game

instead of:

file:/Users/eduardobautista/Projects/guessing_game

I can make the addition right now before it merges, open a separate PR, or ignore it if you already have it covered.

@steveklabnik
Copy link
Member

Woo! That's a good change. Since nobody has actually done an r+ yet, go ahead and add it here as another commit.

@EduardoBautista
Copy link
Contributor Author

@steveklabnik Done. I also added a change to update all the version numbers. I only did the ones in chapter 14, completely forgot about the rest.

@steveklabnik
Copy link
Member

This needs a rebase. Sorry about that!

is kind of like `cargo build`, but it also then runs the produced exectuable.
Try it out:

```{notrust,ignore}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveklabnik Did you remove these lines of code from the guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured it out...

@EduardoBautista
Copy link
Contributor Author

@steveklabnik OK, should be ready.

@steveklabnik
Copy link
Member

Thank you!

bors added a commit that referenced this pull request Aug 21, 2014
…klabnik

Just some small fixes for the guide.  The cargo stuff is probably because of an update.
@bors bors closed this Aug 21, 2014
@bors bors merged commit 48c0f59 into rust-lang:master Aug 21, 2014
@EduardoBautista EduardoBautista deleted the chapter-14-fixes branch August 21, 2014 17:43
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 11, 2024
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
fix: use 4 spaces for indentation in macro expansion

Partial fix for rust-lang#16471.

In the previous code, the indentation produced by macro expansion was set to 2 spaces. This PR modifies it to 4 spaces for the sake of consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants