New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds with LLVM < 3.6 #16520

Merged

bors merged 1 commit into rust-lang:master from dotdash:fix_llvm_before_36

Aug 16, 2014

Contributor

dotdash commented Aug 15, 2014

No description provided.


          Fix builds with LLVM < 3.6

f1f67b2

bors added a commit that referenced this pull request


          auto merge of #16520 : dotdash/rust/fix_llvm_before_36, r=thestinger

ec9476c

bors closed this

bors merged commit f1f67b2 into rust-lang:master

dotdash deleted the fix_llvm_before_36 branch

February 4, 2015 12:41

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#16696 - ShoyuVanilla:fix-goto-deref-mut, r=Ve…

a41cec9

…ykril

fix: Goto definition for `deref_mut`

Fixes rust-lang#16520

https://github.com/rust-lang/rust-analyzer/blob/a3236be9d7a8179ac4a997858138a4d6c260a451/crates/hir/src/source_analyzer.rs#L375-L393

As we can see from the above, current implementation routes all dereferencing prefix operations to `Deref::deref` implementation, not regarding mutabilities.

https://github.com/rust-lang/rust-analyzer/blob/a3236be9d7a8179ac4a997858138a4d6c260a451/crates/hir-ty/src/infer/mutability.rs#L134-L151

Since we are resolving them already in mutability inferences, we can use those results for proper `deref` / `deref_mut` routing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet