Use cargo run in more places #16752
Merged
Use cargo run in more places #16752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! In the future, to edit a PR, you don't need to close the PR: just force push to the same branch, and it updates the pull request. |
|
@steveklabnik Ah, ok, thanks! |
|
It's one of those github tricks you learn after a while :) |
|
Make sure you comment as well when you do that, because github won't notify anyone about the force-push. |
|
@kballard Sure thanks for the tips! 👍 |
|
As @bors 's paranoia grows, he doesn't even trust Cargo anymore, one of his closest allies :-) |
MatejLach
force-pushed
the
more_cargorun
branch
from
4dd017c to
14bda12
Compare
bors
added a commit
that referenced
this pull request
Aug 27, 2014
Use cargo run as much as possible...
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2024
…, r=Veykril fix: Don't destructure struct with no public fields Unfortunately I missed this case in rust-lang#16638. If a struct only has private members, the assist should not be applicable. Though valid syntax exists (`Foo { .. }`), it isn't particularly useful. Since this case applies to a lot of common types (`Arc`, `Vec`, ...), it probably makes the most sense to hide the action. As a side effect, this also disables the action for unit structs, where it also isn't particularly useful. I'd be open to changing it though if you think it makes more sense to keep it. This also fixes the `make::record_pat_field_list` function to produce valid syntax if the field list is empty, as it is used in other places too. ## Current behaviour ```rust // In crate `other_crate` pub struct Foo { bar: i32 } // In current crate fn do_something(foo: other_crate::Foo) {} // Becomes fn do_something(other_crate::Foo { , .. }: other_crate::Foo) {} ``` ## Fixed behaviour Assist should not be applicable in this case anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cargo run as much as possible...