rustdoc: Don't assume that a doc attribute was sugared: Fixes #15976 #16766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just making sure, but you've confirmed that the docs for std don't look funny? (they're the ones with the most reexports) |
|
Docs for I also manually tested, but wasn't sure how I'd include an automated test involving rustdoc and multiple crates:
|
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2024
fix: keep attributes in assist 'generate_delegate_trait' fix rust-lang#15198. This PR address the issue that `impl` generated by `generate_delegate_trait` doesn't keep attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 8876ce4,
is_sugared_docis encoded in metadata, so there is noneed to assume that all
docattributes came from sugared comments.Fixes #15976