Skip to content

Tweak error message for use of a keyword in ident position. #16839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2014
Merged

Tweak error message for use of a keyword in ident position. #16839

merged 1 commit into from
Aug 31, 2014
+12 −12

Conversation

treeman
Copy link
Contributor

@treeman treeman commented Aug 29, 2014

Closes #15358

huonw
huonw reviewed Aug 29, 2014
View reviewed changes
src/doc/guide.md
@@ -630,7 +630,7 @@ In Rust, however, using `let` to introduce a binding is _not_ an expression. The
following will produce a compile-time error:

```{ignore}
let x = (let y = 5i); // found `let` in ident position
let x = (let y = 5i); // expected identifier, found kewyord `let`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made the error message have a spelling mistake? :P (s/wy/yw/)

@treeman
Copy link
Contributor Author

treeman commented Aug 29, 2014

Rebased spelling mistake. :)

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 29, 2014
@alexcrichton
rollup merge of rust-lang#16839 : treeman/issue-15358

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2a38ed1
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 31, 2014
@alexcrichton
rollup merge of rust-lang#16839 : treeman/issue-15358
d1a5b27
@bors bors merged commit 5bf1b03 into rust-lang:master Aug 31, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#16839 - Wilfred:extension_refactor_for_shell,…
f6e2895 
… r=Veykril

Refactor extension to support arbitrary shell command runnables

Currently, the extension assumes that all runnables invoke cargo. Arguments are sometimes full CLI arguments, and sometimes arguments passed to a cargo subcommand.

Refactor the extension so that tasks are just a `program` and a list of strings `args`, and rename `CargoTask` to `RustTask` to make it generic.

(This was factored out of rust-lang#16135 and tidied.)
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 7, 2024
@bors
Auto merge of rust-lang#16970 - Wilfred:fix_tasks, r=Veykril
bbe5ab9 
Fix tasks in tasks.json

rust-lang#16839 refactored the representation of tasks inside the VS Code extension. However, this data type is exposed to users, who can define their own tasks in the same format in `tasks.json` or `.code-workspace`.

Revert the data type to have a `command` field rather than a `program` field, and document the different fields. This code is also a little complex, so split out a `cargoToExecution` to handle the Task to Execution conversion logic.

After this change, any tasks.json with a `command` field works again. For example, the following tasks.json works as expected:

```
{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "cargo",
			"command": "build",
			"problemMatcher": [
			  "$rustc"
			],
			"group": "build",
			"label": "my example cargo build task"
		}
	]
}
```

Fixes rust-lang#16943 rust-lang#16949
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
@bors
Auto merge of rust-lang#16970 - Wilfred:fix_tasks, r=Veykril
f3f14d4 
Fix tasks in tasks.json

rust-lang#16839 refactored the representation of tasks inside the VS Code extension. However, this data type is exposed to users, who can define their own tasks in the same format in `tasks.json` or `.code-workspace`.

Revert the data type to have a `command` field rather than a `program` field, and document the different fields. This code is also a little complex, so split out a `cargoToExecution` to handle the Task to Execution conversion logic.

After this change, any tasks.json with a `command` field works again. For example, the following tasks.json works as expected:

```
{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "cargo",
			"command": "build",
			"problemMatcher": [
			  "$rustc"
			],
			"group": "build",
			"label": "my example cargo build task"
		}
	]
}
```

Fixes rust-lang#16943 rust-lang#16949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message for use of a keyword in ident position could be tweaked
3 participants
@treeman @huonw @bors