librustc: Change the syntax of subslice matching to use postfix ..
#17054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me with a test for the new syntax and a test for the old syntax printing an error |
| "another `mod` import appears here"); | ||
| for &other_span in other.iter() { | ||
| self.session.span_note(other_span, | ||
| if mod_spans.len() > 2 { |
There was a problem hiding this comment.
This should be mod_spans.len() >= 2 or > 1.
Which is arguably why I'd consider the older version a little clearer in that regard.
instead of prefix `..`.
This breaks code that looked like:
match foo {
[ first, ..middle, last ] => { ... }
}
Change this code to:
match foo {
[ first, middle.., last ] => { ... }
}
RFC rust-lang#55.
Closes rust-lang#16967.
[breaking-change]
pcwalton
force-pushed
the
subslice-syntax
branch
from
2c4cc68 to
eb678ff
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 9, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Revert "fix: set the right postfix snippets competion source range" This reverts commit c5686c8. Fix rust-lang#17036. See rust-lang/rust-analyzer#17036 (comment)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Revert "fix: set the right postfix snippets competion source range" This reverts commit c5686c8. Fix rust-lang#17036. See rust-lang/rust-analyzer#17036 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of prefix
...This breaks code that looked like:
Change this code to:
RFC #55.
Closes #16967.
[breaking-change]
r? @brson