Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case-insensitive environment variable names on Windows for process spawning. #17249

Merged
merged 2 commits into from
Sep 18, 2014
Merged

Case-insensitive environment variable names on Windows for process spawning. #17249

merged 2 commits into from
Sep 18, 2014

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Sep 14, 2014

Closes #16937

@brson
Copy link
Contributor

brson commented Sep 15, 2014

Can you mention in the docs for Command that the environment variable is case-insensitive, and whether it gets turned into upper- or lower-case?

Also, if we're going to do this for Command should we also do something similar for os::setenv and os::getenv?

alexcrichton
alexcrichton reviewed Sep 15, 2014
View reviewed changes
src/libstd/io/process.rs
#[doc(hidden)]
#[cfg(windows)]
#[deriving(Eq, Clone, Show)]
pub struct EnvKey(CString);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these stay private to this module?

@vadimcn
Copy link
Contributor Author

vadimcn commented Sep 16, 2014

Updated.
getenv()/setenv() already handle case correctly, because they just defer to the OS API..

@vadimcn
Copy link
Contributor Author

vadimcn commented Sep 17, 2014

Rebased. r?

@vadimcn
Copy link
Contributor Author

vadimcn commented Sep 18, 2014

re-r?

bors added a commit that referenced this pull request Sep 18, 2014
@bors
auto merge of #17249 : vadimcn/rust/env-keys, r=alexcrichton
3638225 
Closes #16937
bors added a commit that referenced this pull request Sep 18, 2014
@bors
auto merge of #17249 : vadimcn/rust/env-keys, r=alexcrichton
482e778 
Closes #16937
@bors bors closed this Sep 18, 2014
@bors bors merged commit 8b84911 into rust-lang:master Sep 18, 2014
@vadimcn vadimcn deleted the env-keys branch March 1, 2015 08:03
@ehuss ehuss mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: process::Command::env should be case-insensitive
5 participants
@vadimcn @brson @alexcrichton @sfackler @bors