Update manual #17402
Merged
Update manual #17402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This looks good. r+ from me, modulo the nits above. (Perhaps ignore the DST comment, updating the docs to be correct with respect to DST is probably a separate PR, and a bit challenging right now since DST is a moving target impl wise (though gradually becoming stationary).) |
steveklabnik
force-pushed
the
update_manual
branch
from
46e8bb4
to
8e24001
Compare
|
I've fixed the one nit, the second is DST, which I agree with being something later. r? |
steveklabnik
force-pushed
the
update_manual
branch
from
8e24001
to
a795b56
Compare
|
r=me needs rebase |
'reference' sounds better than 'manual' to me here, and rust.html is certainly wrong. I also wrapped everything to 80 cols.
This is just true of all of Rust, and doesn't make a lot of sense now. Especially as we move towards finalizing things, I think it's time for this to go.
it's just 'box' not 'owned box'
it's 1:1 by default now, and N:M is on its way out
steveklabnik
force-pushed
the
update_manual
branch
from
a795b56
to
c765178
Compare
|
0169218#diff-5b9531258e65a8733242b78f81019edd was the merge conflict, was easy to forward port. |
bors
added a commit
that referenced
this pull request
Sep 23, 2014
Because I'm still 😷 😷 😷 , I figured some mindless tasks would be better than trying to finish the ownership guide. The manual has long been waiting for some ❤️ ❤️ ❤️ , and so I gave it a quick once-over. I made small commits in case any of the changes are a bit weird, I mostly did a few things: 1. changed 'manual' to 'reference.' I feel like this name is better. If it's not, It's not a huge deal. it shouldn't be `rust.md` though. 2. word wrapped everything appropriately. Changes 1&2 are in the first commit, so that its' easier to see the changes in the later ones. 3. fixed other small style issues 4. removed references to things that are in the standard library, and not the language itself There's still lots of gross in here, but I didn't want to pile on too too many changes. /cc @brson @nikomatsakis
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
fix: avoid doubling cargo args in runnables Fixes rust-lang#17402. Sorry about this—I think I missed up the rebase!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I'm still 😷 😷 😷 , I figured some mindless tasks would be better than trying to finish the ownership guide.
The manual has long been waiting for some ❤️ ❤️ ❤️ , and so I gave it a quick once-over. I made small commits in case any of the changes are a bit weird, I mostly did a few things:
rust.mdthough.There's still lots of gross in here, but I didn't want to pile on too too many changes.
/cc @brson @nikomatsakis