librustc: Some borrowck error message fixes #17434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nikomatsakis or @pnkfelix |
ftxqxd
force-pushed
the
borrowck-messages
branch
from
9d32314
to
74bd252
Compare
|
Looks good except for the terminology around collateral moves. |
Previously it output `partially moved` to eagerly. This updates it to be more accurate and output `collaterally moved` for use of values that were invalidated by moves out of different fields in the same struct. Closes rust-lang#15630.
ftxqxd
force-pushed
the
borrowck-messages
branch
from
74bd252
to
02c6ebd
Compare
|
OK, I’ve updated the ‘use of moved value’ messages to be more similar to the borrow messages. r? |
|
@P1start thanks, this is nice. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
…rs, r=Veykril docs: document omission heuristics for parameter inlay hints These are not currently documented and could cause users to think that their rust-analyzer configuration is broken. Partially addresses rust-lang#17433.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of #17215.
Closes #15506.
Closes #15630.
Closes #17263.
This also partially implements #15838.