Remove ty_bot from the type system #17603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jakub- assigning myself, sorry for delay, it's been a busy week or so. |
|
@nikomatsakis Thanks. This PR isn't compiling yet, AFAIR, due to some unconstrained variables in rustc but the general direction is mostly set. I will rebase soon. |
|
ping @jakub-, any updates here? |
|
@alexcrichton @nikomatsakis This now bootstraps so I'd appreciate your review. |
|
This is green now. |
added 3 commits
October 28, 2014 17:54
We now instead use a fresh variable for expressions that diverge.
bors
added a commit
that referenced
this pull request
Oct 28, 2014
We now instead use a fresh variable for expressions that diverge. Closes #14973. Closes #13847. [Work in progress] cc @nikomatsakis
ghost
deleted the
|
Nice work. |
|
@nikomatsakis Cheers! |
edwardw
added a commit
to edwardw/rust
that referenced
this pull request
Feb 6, 2015
PR rust-lang#17603 introduced bottom type fallback but did it a bit too eagerly. This patch makes the fallback lazy so that `typeck` can run its cause and detect as many type errors as possible with regard to diverging types. Closes rust-lang#21878
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
Switch token trees to use Symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now instead use a fresh variable for expressions that diverge.
Closes #14973.
Closes #13847.
[Work in progress]
cc @nikomatsakis