Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold MethodOrigins to resolve inference variables they may contain. #17663

Merged
merged 1 commit into from
Oct 2, 2014
Merged

Fold MethodOrigins to resolve inference variables they may contain. #17663

merged 1 commit into from
Oct 2, 2014

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Sep 30, 2014

Fixes #17662.

@eddyb
Copy link
Member Author

eddyb commented Sep 30, 2014

cc @nikomatsakis @pcwalton @pnkfelix

@eddyb
Copy link
Member Author

eddyb commented Oct 1, 2014

This is blocking development of my safe-ty branch which replaces the unsafety in rustc::middle::ty with lifetimes.
I would be thankful if this tiny fix made it into the next snapshot.

bors added a commit that referenced this pull request Oct 2, 2014
@bors
auto merge of #17663 : eddyb/rust/method-origin-subst, r=nikomatsakis
b419e9e 
Fixes #17662.
@bors bors closed this Oct 2, 2014
@bors bors merged commit 79d4540 into rust-lang:master Oct 2, 2014
@eddyb eddyb deleted the method-origin-subst branch October 2, 2014 15:09
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 13, 2024
@bors
Auto merge of rust-lang#17705 - huntc:resolve-ra, r=Veykril
d646f7b 
feat: Use oldest rustup rust-analyzer when toolchain override is present

Selects a rust-toolchain declared RA based on its date. The earliest (oldest) RA wins and becomes the one that the workspace uses as a whole.

In terms of precedence:

nightly > stable-with-version > stable

With stable-with-version, we invoke the RA with a `--version` arg and attempt to extract a date. Given the same date as a nightly, the nightly RA will win.

Fixes rust-lang#17663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: cannot encode region variables, for trait object method calls.
5 participants
@eddyb @nikomatsakis @huonw @thestinger @bors