-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gc (garbage "collected") boxes. #17666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An absolutely heroic effort made by @eddyb leading up to this, amazing work! |
Very impressive. |
Read everything up until the WIP commit. R+ to all those modulo nits. |
eddyb
force-pushed
the
take-garbage-out
branch
from
October 1, 2014 21:23
3277075
to
78f9512
Compare
eddyb
changed the title
[WIP] Remove Gc (garbage "collected") boxes.
Remove Gc (garbage "collected") boxes.
Oct 1, 2014
eddyb
force-pushed
the
take-garbage-out
branch
2 times, most recently
from
October 2, 2014 05:12
ab07550
to
ca87704
Compare
eddyb
force-pushed
the
take-garbage-out
branch
from
October 2, 2014 14:03
ca87704
to
58bea31
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 2, 2014
Conflicts: src/libcollections/lib.rs src/libcore/lib.rs src/librustdoc/lib.rs src/librustrt/lib.rs src/libserialize/lib.rs src/libstd/lib.rs src/test/run-pass/issue-8898.rs
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All good things must come to an end. Even the really bad ones.
[breaking-change] (hopefully nobody was using it)
Closes #17668.