Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gc (garbage "collected") boxes. #17666

Merged
merged 13 commits into from
Oct 3, 2014
Merged

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Sep 30, 2014

All good things must come to an end. Even the really bad ones.

[breaking-change] (hopefully nobody was using it)

Closes #17668.

@eddyb
Copy link
Member Author

eddyb commented Sep 30, 2014

cc @nikomatsakis @pcwalton @pnkfelix

@alexcrichton
Copy link
Member

An absolutely heroic effort made by @eddyb leading up to this, amazing work!

@nikomatsakis
Copy link
Contributor

Very impressive.

@nikomatsakis
Copy link
Contributor

Read everything up until the WIP commit. R+ to all those modulo nits.

@eddyb eddyb changed the title [WIP] Remove Gc (garbage "collected") boxes. Remove Gc (garbage "collected") boxes. Oct 1, 2014
@eddyb eddyb force-pushed the take-garbage-out branch 2 times, most recently from ab07550 to ca87704 Compare October 2, 2014 05:12
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 2, 2014
Conflicts:
	src/libcollections/lib.rs
	src/libcore/lib.rs
	src/librustdoc/lib.rs
	src/librustrt/lib.rs
	src/libserialize/lib.rs
	src/libstd/lib.rs
	src/test/run-pass/issue-8898.rs
@bors bors merged commit 58bea31 into rust-lang:master Oct 3, 2014
@eddyb eddyb deleted the take-garbage-out branch October 3, 2014 07:50
lnicola pushed a commit to lnicola/rust that referenced this pull request Jul 28, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Gc
5 participants