Skip to content

Fix quote_method! #17787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2014
Merged

Fix quote_method! #17787

merged 1 commit into from
Oct 8, 2014

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 5, 2014

The previous fix introduced in 75d49c8 neglected to parse outer attributes as described in #17782.

@huonw
Copy link
Member

huonw commented Oct 5, 2014

Could you add a test for this, iirc there's a pile in src/test/run-pass-fulldeps/qquote.rs or something? (Also, if you write "closes #17782" in the PR description or commit message, Github will automatically close that issue when this code lands.)

@bgamari
Copy link
Contributor Author

bgamari commented Oct 6, 2014

@huonw, well, I added a test to qquote unfortunately I soon realized that the test is horribly outdated and is currently ignored. I tried to resuscitate it but it seems that the provision previously allowing fake ParseSesss has been ripped out. Perhaps we can just merge this as-is and open a new issue to track the rehabilitation of the quasi-quoting tests?

@huonw
Copy link
Member

huonw commented Oct 6, 2014

Hm, I may have misled you, sorry; there's a file in that directory that just has a series of quote macro calls (not doing anything interesting with the result).

(I can't look myself right now.)

@bgamari
Copy link
Contributor Author

bgamari commented Oct 6, 2014

@huonw that should be better.

@bgamari
Copy link
Contributor Author

bgamari commented Oct 6, 2014

That is to say, I've pushed a new patch adding a test to quote-tokens.rs

@farcaller farcaller mentioned this pull request Oct 7, 2014
Closed
bors added a commit that referenced this pull request Oct 7, 2014
@bors
auto merge of #17787 : bgamari/rust/fix-quote-method, r=huonw
3b945dc 
The previous fix introduced in 75d49c8 neglected to parse outer attributes as described in #17782.
@bors bors closed this Oct 8, 2014
@bors bors merged commit a5a11a8 into rust-lang:master Oct 8, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 25, 2024
@bors
Auto merge of rust-lang#18005 - rami3l:fix/for-completion-in-impl, r=…
27979ad 
…Veykril

fix(ide-completion): fix handling of `for` in `impl T for A` in function body

Closes rust-lang#17787.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgamari @huonw @alexcrichton @bors