Fix ICE generating debug info for unboxed closures #17803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an ICE. Closes issue rust-lang#17021
This causes it to hit the previously ICEing debuginfo codepath
|
|
|
@bkoropoff you've been on quite a roll recently, thanks so much for investigating all these problems! |
|
@bkoropoff Thank you for writing this. |
|
Hmm, after running through a full make check, I'm seeing debuginfo/evec-in-struct.rs fail, but I don't see how it could be related since the test does not use closures or unboxed closures at all. |
|
I see it even using rustc as of c586490, so I don't think it's related to this PR. My first suspicion would be the llvm upgrade. I'll file a separate issue. |
tomassedovic
added a commit
to tomassedovic/tcod-rs
that referenced
this pull request
Oct 9, 2014
tomassedovic
added a commit
to tryjumping/dose-response
that referenced
this pull request
Nov 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #17021.