test: make the sort failure-safety test unsafeless and more obvious. #18031
+43
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it had some uninituitive conditionals due to the interaction with the Rand construction and Clone reinitialisation to create sequential identifying numbers. This replaces all that with just constructing the DropCounters with the appropriate identifiers.
|
(Just some clean-up I noticed while filing #18030.) |
bors
added a commit
that referenced
this pull request
Oct 15, 2014
Previously it had some uninituitive conditionals due to the interaction with the Rand construction and Clone reinitialisation to create sequential identifying numbers. This replaces all that with just constructing the DropCounters with the appropriate identifiers.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
…eykril feat: Suggest name in completion for let_stmt and fn_param fix rust-lang#17780 1. Refactor: move `ide_assist::utils::suggest_name` to `ide-db::syntax_helpers::suggest_name` for reuse. 2. When completing `IdentPat`, detecte if the current node is a `let_stmt` or `fn_param`, and suggesting a new name based on the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it had some uninituitive conditionals due to the interaction
with the Rand construction and Clone reinitialisation to create
sequential identifying numbers. This replaces all that with just
constructing the DropCounters with the appropriate identifiers.