Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make the sort failure-safety test unsafeless and more obvious. #18031

Merged
merged 1 commit into from
Oct 15, 2014

Conversation

huonw
Copy link
Member

@huonw huonw commented Oct 14, 2014

Previously it had some uninituitive conditionals due to the interaction
with the Rand construction and Clone reinitialisation to create
sequential identifying numbers. This replaces all that with just
constructing the DropCounters with the appropriate identifiers.

Previously it had some uninituitive conditionals due to the interaction
with the Rand construction and Clone reinitialisation to create
sequential identifying numbers. This replaces all that with just
constructing the DropCounters with the appropriate identifiers.
@huonw
Copy link
Member Author

huonw commented Oct 14, 2014

(Just some clean-up I noticed while filing #18030.)

bors added a commit that referenced this pull request Oct 15, 2014
Previously it had some uninituitive conditionals due to the interaction
with the Rand construction and Clone reinitialisation to create
sequential identifying numbers. This replaces all that with just
constructing the DropCounters with the appropriate identifiers.
@bors bors closed this Oct 15, 2014
@bors bors merged commit 32513b0 into rust-lang:master Oct 15, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 25, 2024
…eykril

feat: Suggest name in completion for let_stmt and fn_param

fix rust-lang#17780

1. Refactor: move `ide_assist::utils::suggest_name` to `ide-db::syntax_helpers::suggest_name` for reuse.
2. When completing `IdentPat`, detecte if the current node is a `let_stmt` or `fn_param`, and suggesting a new name based on the context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants