Transmute cleanup #18318
Merged
Transmute cleanup #18318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arielb1
force-pushed
the
transmute-cleanup
branch
from
d80fad6 to
ec8782a
Compare
| index: &mut Vec<entry<i64>>) { | ||
| let mut rbml_w = unsafe { rbml_w.unsafe_clone() }; | ||
| // See above | ||
| let ecx: &EncodeContext = unsafe { mem::transmute(ecx_ptr) }; |
|
LGTM, but there's enough unsafe code here that I'd like a second look. |
| @@ -798,7 +786,8 @@ fn get_metadata_section_imp(os: abi::Os, filename: &Path) -> Result<MetadataBlob | |||
| let csz = llvm::LLVMGetSectionSize(si.llsi) as uint; | |||
| let mut found = | |||
| Err(format!("metadata not found: '{}'", filename.display())); | |||
| let cvbuf: *const u8 = mem::transmute(cbuf); | |||
| let cvbuf: *const u8 = mem::transmute::<*const i8, | |||
| *const u8>(cbuf); | |||
There was a problem hiding this comment.
This doesn't need to be a transmute a simple as cast should work.
arielb1
force-pushed
the
transmute-cleanup
branch
from
ec8782a to
1cd9de6
Compare
|
Some of the transmutes here are DST-related and are waiting for a new snapshot with #17178. |
|
@arielb1 should the r+ be removed until new snapshot lands? |
|
This PR is snapshot-independent. Some further cleanup is waiting on #18291. |
arielb1
force-pushed
the
transmute-cleanup
branch
from
1cd9de6 to
795d563
Compare
|
@arielb1 looks like this needs to be rebased |
None of them would break by implementation-defined struct layout, but one would break with strict lifetime aliasing, and the rest are just ugly code.
arielb1
force-pushed
the
transmute-cleanup
branch
from
795d563 to
a87078a
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-up transmutes in librustc and libsyntax