rustc: Implement -l and include! tweaks #18470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // ignore-test: this is not a test |
There was a problem hiding this comment.
Seems like it'd be less sketchy to put these in auxilliary.
|
r=me with comments addressed |
This is an implementation of the rustc bits of [RFC 403][rfc]. This adds a new flag to the compiler, `-l`, as well as tweaking the `include!` macro (and related source-centric macros). The compiler's new `-l` flag is used to link libraries in from the command line. This flag stacks with `#[link]` directives already found in the program. The purpose of this flag, also stated in the RFC, is to ease linking against native libraries which have wildly different requirements across platforms and even within distributions of one platform. This flag accepts a string of the form `NAME[:KIND]` where `KIND` is optional or one of dylib, static, or framework. This is roughly equivalent to if the equivalent `#[link]` directive were just written in the program. The `include!` macro has been modified to recursively expand macros to allow usage of `concat!` as an argument, for example. The use case spelled out in RFC 403 was for `env!` to be used as well to include compile-time generated files. The macro also received a bit of tweaking to allow it to expand to either an expression or a series of items, depending on what context it's used in. [rfc]: rust-lang/rfcs#403
|
Shouldn't |
|
The helper function that I modified was actually called by both of them as well, so that whole family of macros should benefit! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 31, 2014
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 3, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Nov 4, 2024
Allow interpreting consts and statics with interpret function command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the rustc bits of RFC 403. This adds a new
flag to the compiler,
-l, as well as tweaking theinclude!macro (andrelated source-centric macros).
The compiler's new
-lflag is used to link libraries in from the command line.This flag stacks with
#[link]directives already found in the program. Thepurpose of this flag, also stated in the RFC, is to ease linking against native
libraries which have wildly different requirements across platforms and even
within distributions of one platform. This flag accepts a string of the form
NAME[:KIND]whereKINDis optional or one of dylib, static, or framework.This is roughly equivalent to if the equivalent
#[link]directive were justwritten in the program.
The
include!macro has been modified to recursively expand macros to allowusage of
concat!as an argument, for example. The use case spelled out in RFC403 was for
env!to be used as well to include compile-time generated files.The macro also received a bit of tweaking to allow it to expand to either an
expression or a series of items, depending on what context it's used in.
Closes #18473