Replace unsafety in middle::ty with lifetimes. #18483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eddyb
force-pushed
the
safe-ty
branch
3 times, most recently
from
71a8e82 to
315aa8d
Compare
|
This is cool stuff |
eddyb
force-pushed
the
safe-ty
branch
2 times, most recently
from
0448038 to
3a00e42
Compare
eddyb
force-pushed
the
safe-ty
branch
2 times, most recently
from
f58aad6 to
d12acd8
Compare
|
r+ @eddyb from what I can tell, this PR is a work of art. Thanks for doing such a good job separating out the commits like you did, that really makes this easier to read. |
|
@eddyb btw I put the r+ on the PR, not the commit, so you could address the question regarding the comparison. |
eddyb
force-pushed
the
safe-ty
branch
4 times, most recently
from
a0d0b39 to
789797b
Compare
bors
added a commit
that referenced
this pull request
Nov 19, 2014
After more than a month of sitting on this patch, rebasing and tracking down some nasty bugs (there's might be still one out there, but it only manifested in `middle::trans::reflect` which is now gone), I'd like to merge it as it is. This changeset makes middle::ty safe, linking the lifetime of a type to the type context it was created in. It's a prerequisite for introducing function-local type contexts to localize types with inference variables, in order to (potentially) free hundreds of MBs from rustc's memory usage peak.
|
Wow, congratulations! |
|
/me goes to rebase everything |
|
Amazing. Congratulations, @eddyb. :) |
|
🎉 🎈 🎂 |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 11, 2024
…roduce_named_generic Migrate `introduce_named_generic` Assist to Use `SyntaxFactory`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more than a month of sitting on this patch, rebasing and tracking down some nasty bugs (there's might be still one out there, but it only manifested in
middle::trans::reflectwhich is now gone), I'd like to merge it as it is.This changeset makes middle::ty safe, linking the lifetime of a type to the type context it was created in.
It's a prerequisite for introducing function-local type contexts to localize types with inference variables, in order to (potentially) free hundreds of MBs from rustc's memory usage peak.