Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obscure ICE in trans (#18514) #18518

Merged
merged 2 commits into from
Nov 3, 2014
Merged

Conversation

bkoropoff
Copy link
Contributor

Don't ICE when translating a generic impl method from an extern crate that contains a match expression on a local variable lvalue where one of the match case bodies contains an expression that autoderefs through an overloaded generic deref impl and we neglect to monomorphize the result type of the deref method.

Closes #17810
Closes #18514

In some obscure circumstances, failure to do this can cause
unsubstituted type parameters to show up where they aren't
expected and cause an ICE.

Closes rust-lang#18514
@ghost
Copy link

ghost commented Nov 2, 2014

Also closes #17810, I think. I edited the PR description accordingly but it'd be good to double check once this lands.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 3, 2014
@bors bors merged commit 09cc2f1 into rust-lang:master Nov 3, 2014
lnicola added a commit to lnicola/rust that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants